Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustfmt: Run on util/* (2/2) #3323

Open
wants to merge 42 commits into
base: main
Choose a base branch
from
Open

rustfmt: Run on util/* (2/2) #3323

wants to merge 42 commits into from

Conversation

tnull
Copy link
Contributor

@tnull tnull commented Sep 18, 2024 •
edited
Loading

This is PR 2/2, based on #3324.

The diff is a bit larger for this one, but AFAICT the changes look mostly reasonable (besides the oddity commented below).

FWIW, I had a look at currently open inflight PRs and the conflicts should be minimal if I'm not overlooking something.

@codecov Codecov
Copy link

codecov bot commented Sep 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 83.70787% with 232 lines in your changes missing coverage. Please review.

Project coverage is 89.60%. Comparing base (66fb520) to head (e2dcdc7).

Files with missing lines Patch % Lines
lightning/src/util/test_channel_signer.rs 48.17% 8 Missing and 77 partials ⚠️
lightning/src/util/test_utils.rs 83.59% 71 Missing and 2 partials ⚠️
lightning/src/util/persist.rs 89.41% 17 Missing and 3 partials ⚠️
lightning/src/util/ser.rs 73.84% 17 Missing ⚠️
lightning/src/util/ser_macros.rs 91.59% 9 Missing and 1 partial ⚠️
lightning/src/util/wakers.rs 93.00% 5 Missing and 2 partials ⚠️
lightning/src/util/transaction_utils.rs 95.71% 3 Missing and 3 partials ⚠️
lightning/src/util/macro_logger.rs 87.87% 0 Missing and 4 partials ⚠️
lightning/src/util/message_signing.rs 50.00% 4 Missing ⚠️
lightning/src/util/errors.rs 72.72% 3 Missing ⚠️
... and 1 more
Additional details and impacted files 
@@           Coverage Diff            @@
##             main    #3323    +/-   ##
========================================
  Coverage   89.59%   89.60%            
========================================
  Files         126      126            
  Lines      102676   103419   +743     
  Branches   102676   103419   +743     
========================================
+ Hits        91995    92668   +673     
- Misses       7947     7984    +37     
- Partials     2734     2767    +33

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tnull tnull force-pushed the 2024-09-rustfmt-util branch 2 times, most recently from 6c4dd83 to 9b991df Compare September 18, 2024 08:42
@TheBlueMatt
Copy link
Collaborator

Ugh, can we split this? 42 commits in one PR is just a lot...

@tnull tnull mentioned this pull request Sep 18, 2024
Open
@tnull
Copy link
Contributor Author

tnull commented Sep 18, 2024

Ugh, can we split this? 42 commits in one PR is just a lot...

Alright, happy to if you prefer (although at least half of these commits are one-line diffs). Now split out ~the first half of commits to #3324.

@tnull tnull changed the title rustfmt: Run on util/* rustfmt: Run on util/* (2/2) Sep 18, 2024
@tnull
rustfmt: Run on util/atomic_counter.rs
95fd1f7
@tnull
rustfmt: Drop util/atomic_counter.rs from exclusion list
ebb213f
@tnull
rustfmt: Run on util/base32.rs
8e2c0e2
@tnull
rustfmt: Drop util/base32.rs from exclusion list
ece7aab
@tnull
rustfmt: Run on util/byte_utils.rs
8e50630
@tnull
rustfmt: Drop util/byte_utils.rs from exclusion list
9cb979d
@tnull
rustfmt: Run on util/config.rs
fff097a
@tnull
rustfmt: Drop util/config.rs from exclusion list
719d147
@tnull
rustfmt: Run on util/errors.rs
32b55bb
@tnull
rustfmt: Drop util/errors.rs from exclusion list
6b36273
@tnull
rustfmt: Run on util/fuzz_wrappers.rs
8fb3c3f
@tnull
rustfmt: Drop util/fuzz_wrappers.rs from exclusion list
c9bae0e
@tnull
rustfmt: Run on util/indexed_map.rs
f26001f
@tnull
rustfmt: Drop util/indexed_map.rs from exclusion list
ea22956
@tnull
rustfmt: Run on util/logger.rs
9c6c9ab
@tnull
rustfmt: Drop util/logger.rs from exclusion list
7d6dc78
@tnull
rustfmt: Run on util/macro_logger.rs
7753645
@tnull
rustfmt: Drop util/macro_logger.rs from exclusion list
bd28ad0
@tnull
rustfmt: Run on util/message_signing.rs
c1495ef
@tnull
rustfmt: Run on util/persist.rs
7e276f2
@tnull
rustfmt: Drop util/persist.rs from exclusion list
d68a484
@tnull
rustfmt: Run on util/scid_utils.rs
9082139
@tnull
rustfmt: Drop util/scid_utils.rs from exclusion list
b8a0c99
@tnull
rustfmt: Run on util/ser.rs
1f44996
@tnull
rustfmt: Drop util/ser.rs from exclusion list
8fccea9
@tnull
rustfmt: Run on util/ser_macros.rs
1b8cc42
@tnull
rustfmt: Drop util/ser_macros.rs from exclusion list
215b1a4
@tnull
rustfmt: Run on util/test_channel_signer.rs
5250dc5
@tnull
rustfmt: Drop util/test_channel_signer.rs from exclusion list
9039f67
@tnull
rustfmt: Prepare util/test_utils.rs
ab6e410 
.. we pull out `Mutex` field initialization into dedicated variables as
they might otherwise land on the same line when formatting, which might
lead to lockorder violation false-positives when compiled with the
`backtrace` feature.
@tnull
rustfmt: Run on util/test_utils.rs
da540bc
@tnull
rustfmt: Drop util/test_utils.rs from exclusion list
b746473
@tnull
rustfmt: Run on util/time.rs
1c5494a
@tnull
rustfmt: Drop util/time.rs from exclusion list
5a3733f
@tnull
rustfmt: Run on util/transaction_utils.rs
12b1124
@tnull
rustfmt: Drop util/transaction_utils.rs from exclusion list
9664e44
@tnull
rustfmt: Run on util/wakers.rs
074814f
@tnull
rustfmt: Drop util/wakers.rs from exclusion list
72a4f2f
@tnull
rustfmt: Run on util/mod.rs
c1abc4a
@tnull
rustfmt: Drop util/mod.rs from exclusion list
51351c6
@tnull
rustfmt: Drop remaining util files from exclusion list
e2dcdc7
@tnull
Copy link
Contributor Author

tnull commented Sep 19, 2024

Rebased after #3327 landed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincenzopalazzo vincenzopalazzo vincenzopalazzo left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
blocked on dependent pr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tnull @TheBlueMatt @vincenzopalazzo