Fix MSRV builds of lightning-transaction-sync in CI
#3304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`lightning-transaction-sync`'s `esplora-async` dependency indirectly depends on `tokio-util`, which, like tokio, recently bumped its MSRV. Here we update `ci/ci-tests.sh` to pin `tokio-util` to make MSRV builds pass.
Now that `lightning-transaction-sync` is in the workspace and covered by our MSRV we should be testing it in our `msrv-no-dev-deps-check` test crate.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3304 +/- ##
==========================================
- Coverage 89.85% 89.62% -0.24%
==========================================
Files 126 126
Lines 104145 102166 -1979
Branches 104145 102166 -1979
==========================================
- Hits 93577 91563 -2014
+ Misses 7894 7872 -22
- Partials 2674 2731 +57 ☔ View full report in Codecov by Sentry. |
TheBlueMatt
force-pushed
the
2024-09-tokio-util-msrv
branch
from
6be240e
to
215295f
Compare
This should marginally reduce the chance of MSRV or other issues in the future, and is just good practice.
TheBlueMatt
force-pushed
the
2024-09-tokio-util-msrv
branch
from
215295f
to
35bc575
Compare
tnull
approved these changes
Sep 9, 2024
tnull
reviewed
Sep 9, 2024
|
Ugh, disabled the linting check being blocking... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.