Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow user-provided payer_signing_pubkey #3264

Merged
merged 4 commits into from
Nov 12, 2024
Merged

Disallow user-provided payer_signing_pubkey #3264

merged 4 commits into from
Nov 12, 2024

Commits on Nov 11, 2024

  1. Replace spaces with tabs

    @jkczyz
    jkczyz committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    ad487e7 View commit details
    Browse the repository at this point in the history

  2. Disallow user-provided payer_signing_pubkey 

    When creating an InvoiceRequests, users may choose to either use a
transient signing pubkey generated by LDK or provide a static one.
Disallow the latter as it allows users to reuse the same pubkey, which
results in poor sender privacy.
    @jkczyz
    jkczyz committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    d596b4e View commit details
    Browse the repository at this point in the history

  3. Remove PayerSigningPubkeyStrategy 

    Now that InvoiceRequest::payer_signing_pubkey is always a derived
pubkey, there is no longer a need for PayerSigningPubkeyStrategy.
    @jkczyz
    jkczyz committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    5af0cf1 View commit details
    Browse the repository at this point in the history

  4. Remove NodeSigner::sign_bolt12_invoice_request 

    Now that invoice requests are signed using transient keys only, remove
the corresponding signing method from NodeSigner since it is never used.
    @jkczyz
    jkczyz committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    c331b67 View commit details
    Browse the repository at this point in the history