-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the core functionality required to resolve Human Readable Names #3179
base: main
Are you sure you want to change the base?
Changes from all commits
cc7c19f
6b760e7
513bb88
e1a87af
4359c89
f49d571
3a6440a
72a01c9
7018be4
eaa1e2e
03406f7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,7 +12,7 @@ Still missing tons of error-handling. See GitHub issues for suggested projects i | |
edition = "2021" | ||
|
||
[package.metadata.docs.rs] | ||
features = ["std"] | ||
features = ["std", "dnssec"] | ||
rustdoc-args = ["--cfg", "docsrs"] | ||
|
||
[features] | ||
|
@@ -32,6 +32,8 @@ unsafe_revoked_tx_signing = [] | |
no-std = ["hashbrown", "possiblyrandom", "libm"] | ||
std = [] | ||
|
||
dnssec = ["dnssec-prover/validation"] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. thinking if we can make the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We maybe could, but it seems nice to use the types from it, and the crate weighs basically nothing if we just pull the types from it and don't enable the validation feature. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I see, and I agree. I was thinking that maybe the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yea, it likely is (and maybe we should make it default, even), but I think even still we can use the types from it no matter what. |
||
|
||
# Generates low-r bitcoin signatures, which saves 1 byte in 50% of the cases | ||
grind_signatures = [] | ||
|
||
|
@@ -44,6 +46,8 @@ lightning-invoice = { version = "0.32.0-rc1", path = "../lightning-invoice", def | |
bech32 = { version = "0.9.1", default-features = false } | ||
bitcoin = { version = "0.32.2", default-features = false, features = ["secp-recovery"] } | ||
|
||
dnssec-prover = { version = "0.6", default-features = false } | ||
tnull marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
hashbrown = { version = "0.13", optional = true, default-features = false } | ||
possiblyrandom = { version = "0.2", path = "../possiblyrandom", optional = true, default-features = false } | ||
regex = { version = "1.5.6", optional = true } | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might want to rebase after #3289 has been merged to double-check there is no silent merge conflict?