Skip to content

Allow to configure seed via a BIP 39 mnemonic #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

tnull
Copy link
Collaborator

@tnull tnull commented Apr 20, 2023

Fixes #47, Based on #64

Since it's unblocked now, we allow users to give the seed via a BIP 39 mnemonic.

@danielnordh
Copy link

Does this also expose the ability to create a mnemonic?
I.e via BDK's Mnemonic() function.

As I currently use BDK to generate the mnemonic for new users I would like to be able to do the same with ldk-node

@tnull
Copy link
Collaborator Author

tnull commented Apr 21, 2023

Does this also expose the ability to create a mnemonic? I.e via BDK's Mnemonic() function.

As I currently use BDK to generate the mnemonic for new users I would like to be able to do the same with ldk-node

In Rust we to this end re-export the bip39 crate for users to have it handy. In bindings, I imagine we'll expose this as a function that just takes the Mnemonic as a string and builds the object for the user.

@danielnordh
Copy link

Does this also expose the ability to create a mnemonic? I.e via BDK's Mnemonic() function.
As I currently use BDK to generate the mnemonic for new users I would like to be able to do the same with ldk-node

In Rust we to this end re-export the bip39 crate for users to have it handy. In bindings, I imagine we'll expose this as a function that just takes the Mnemonic as a string and builds the object for the user.

I would also want a function that GETs a new mnemonic, for first time users.

@tnull tnull force-pushed the 2023-04-allow-mnemonics branch from 68c0e6e to 1e149cb Compare April 25, 2023 08:59
@tnull
Copy link
Collaborator Author

tnull commented Apr 25, 2023

Rebased on main.

@tnull tnull added this to the 0.1 milestone Apr 25, 2023
@tnull tnull merged commit 040b0e4 into lightningdevkit:main Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to read Bip39 mnemonic
3 participants