Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: semantic viewer filter ui bugs #11688

Merged
merged 1 commit into from
Sep 25, 2024
Merged

fix: semantic viewer filter ui bugs #11688

merged 1 commit into from
Sep 25, 2024
+45 −41

Conversation

IrakliJani
Copy link
Contributor

Closes: #11685
Closes: #11438
Bonus: fixed text alignment inconsistencies

fyi, this padding should be enough on all fonts/os variations I think:

CleanShot 2024-09-25 at 19 25 21@2x

Description:

Reviewer actions

  • I have manually tested the changes in the preview environment
  • I have reviewed the code
  • I understand that "request changes" will block this PR from merging

@owlas owlas requested a deployment to fix/semantic-viewer-filter-ui-bugs - jaffle_db_pg_13 PR #11688 September 25, 2024 15:26 — with Render Abandoned
@owlas owlas temporarily deployed to fix/semantic-viewer-filter-ui-bugs - headless-browser PR #11688 September 25, 2024 15:26 — with Render Destroyed
@netlify Netlify
Copy link

netlify bot commented Sep 25, 2024 •
edited
Loading

✅ Deploy Preview for peaceful-bassi-cbf284 canceled.

Name Link
🔨 Latest commit d789c5e
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-bassi-cbf284/deploys/66f42ba40ada380008594a12

@owlas owlas temporarily deployed to fix/semantic-viewer-filter-ui-bugs - lightdash PR #11688 September 25, 2024 15:27 — with Render Destroyed
almeidabbm
almeidabbm approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@almeidabbm almeidabbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a small question 💪

@IrakliJani IrakliJani merged commit b1d01f4 into main Sep 25, 2024
48 of 52 checks passed
@IrakliJani IrakliJani deleted the fix/semantic-viewer-filter-ui-bugs branch September 25, 2024 16:31
lightdash-bot pushed a commit that referenced this pull request Sep 25, 2024
@semantic-release-bot
chore(release): 0.1273.5
f9a9a51 
## [0.1273.5](0.1273.4...0.1273.5) (2024-09-25)

### Bug Fixes

* semantic viewer field select scroll overflow ([#11690](#11690)) ([5f3428b](5f3428b))
* semantic viewer filter ui bugs ([#11688](#11688)) ([b1d01f4](b1d01f4))
@lightdash-bot
Copy link
Collaborator

🎉 This PR is included in version 0.1273.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@almeidabbm almeidabbm almeidabbm approved these changes

@magnew magnew Awaiting requested review from magnew

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

is not is cut off in the filter modal nested filter copy is confusing
4 participants
@IrakliJani @lightdash-bot @almeidabbm @owlas