Skip to content

Commit

Permalink
Merge pull request opencontainers#4511 from kolyshkin/rm-internal-tes…
Browse files Browse the repository at this point in the history
…tutil

ci: rm "skip on CentOS 7" kludges
  • Loading branch information
lifubang authored Nov 9, 2024
2 parents 2fc0caf + 9cb59b4 commit 3a09973
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 39 deletions.
30 changes: 0 additions & 30 deletions internal/testutil/testutil.go

This file was deleted.

5 changes: 0 additions & 5 deletions libcontainer/cgroups/devices/systemd_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import (
"strings"
"testing"

"github.com/opencontainers/runc/internal/testutil"
"github.com/opencontainers/runc/libcontainer/cgroups"
"github.com/opencontainers/runc/libcontainer/cgroups/systemd"
"github.com/opencontainers/runc/libcontainer/configs"
Expand All @@ -27,8 +26,6 @@ func TestPodSkipDevicesUpdate(t *testing.T) {
if os.Geteuid() != 0 {
t.Skip("Test requires root.")
}
// https://github.com/opencontainers/runc/issues/3743.
testutil.SkipOnCentOS(t, "Flaky (#3743)", 7)

podName := "system-runc_test_pod" + t.Name() + ".slice"
podConfig := &configs.Cgroup{
Expand Down Expand Up @@ -126,8 +123,6 @@ func testSkipDevices(t *testing.T, skipDevices bool, expected []string) {
if os.Geteuid() != 0 {
t.Skip("Test requires root.")
}
// https://github.com/opencontainers/runc/issues/3743.
testutil.SkipOnCentOS(t, "Flaky (#3743)", 7)

podConfig := &configs.Cgroup{
Parent: "system.slice",
Expand Down
4 changes: 0 additions & 4 deletions libcontainer/cgroups/file_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,9 @@ import (
"strconv"
"testing"
"time"

"github.com/opencontainers/runc/internal/testutil"
)

func TestWriteCgroupFileHandlesInterrupt(t *testing.T) {
testutil.SkipOnCentOS(t, "Flaky (see #3418)", 7)

const (
memoryCgroupMount = "/sys/fs/cgroup/memory"
memoryLimit = "memory.limit_in_bytes"
Expand Down

0 comments on commit 3a09973

Please sign in to comment.