-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker fixes #699
base: master
Are you sure you want to change the base?
Docker fixes #699
Conversation
hello, |
@panghaichao You need modify the Dockerfile. When build docker image, it's clone from github now, should copy files from local repo. |
Can we merge this PR? This would be super-helpful. The Docker image will be built automatically, IIUC. Maybe the image size also gets reduced by this, automagically, as suggested in #691. |
NOTE: That would be sufficient: def read_file(filename):
with open(filename) as thefile:
return thefile.read()
requires = read_file('requirements.txt') |
This PR, in addition to pinning the Dockerfile image is required to make building this repo work.
Until this repo starts getting maintained again, I've setup a Docker hub autobuild with this PR. |
I noticed the Docker image was also affected by #689, so I set about fixing :)