feat: add pagination to addresses #322
Draft
+77
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added pagination and interface definition to addresses service function for findOne address. Added pagination to addresses controller endpoint for one address. Added pager component to UI for addresses page and added pagination meta to api query.
Fix for tokensQuery not returning all tokens and causing Unknown Tokens across many denoms. Retrieve the first page of 100 tokens (need to refactor later to add pagination). Standardize precision conversion in mint-burn to ledger-send format.
This was referenced Sep 24, 2024
Set precision to token precision in ledger-send, convert to string then use parseFloat to remove trailing 0s.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For addresses with larger numbers of transactions, we were missing pagination on the /addresses/[address] page in the UI. This branch adds pagination to the endpoint in the server and to the UI.
Description
Related Issue
Fixes # (issue)
#318
#320
#306
Testing
Tested locally against a clone of prod database.
Breaking Changes (if applicable)
None
Screenshots (if applicable)
Pager on Address transactions view
Fix of precision on ledger-send:
Checklist: