Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: fetch_cloudos_id function #130

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

Conversation

danielboloc
Copy link
Contributor

Overview

Test job.fetch_cloudos_id function

Purpose

To create all tests considering all scenarios

Acceptance Criteria/Jira Ticket

CLOUDOSCLI-106

Changes

  • Add tests/test_jobs/test_fetch_cloudos_id.py to test all scenarios
  • Add tests/test_data/jobs/fetch_cloudos_id.json as mock data

Tests

image

danielboloc and others added 16 commits October 3, 2022 19:08
* feat(parameters): add  parameter for customization. See #90

* docs: add documentation in changelog and readme

* bump: increse minor version 1.0.0 to 1.1.0

* refactor: replace command line option from cromwell with constant variable

* docs: update about request interval option

* refactor: add control expression to not surpass wait time

* refactor: change variable to the constant for Cromwell jobs
Co-authored-by: dapineyro <[email protected]>
Co-authored-by: dapineyro <[email protected]>
* Add new cost limit as default 30$

* CHANGELOG updated

* VERSION updated

* Update cloudos/__main__.py

Co-authored-by: dapineyro <[email protected]>

* version update

* Update README.md

* version bump to 1.2.1

Co-authored-by: Erdal Genc <[email protected]>
Co-authored-by: dapineyro <[email protected]>
Co-authored-by: Christina Chatzipantsiou <[email protected]>
Co-authored-by: dapineyro <[email protected]>
* fix BadRequestException #84

* make wdl-importsfile optional

* update docs

* simplify code

* simplify code 2

* simplify code 3

* simplify code 4

* small doc change

* fix repo for projects

* Update to prepare a release
* fix BadRequestException #84

* make wdl-importsfile optional

* update docs

* simplify code

* simplify code 2

* simplify code 3

* simplify code 4

* small doc change

* fix repo for projects

* Use API key when no cromwell key is available

* Adds click support

* small help change

* Updates docs

* Minor doc changes
* Pytests added for _create_cromwell_header function

* unused code removed

* Apply suggestions from code review

Co-authored-by: dapineyro <[email protected]>

* new folder for cloudos tests

* init

Co-authored-by: Erdal Genc <[email protected]>
Co-authored-by: dapineyro <[email protected]>
* test: add tests for 'get_job_list'

* refactor: add new assert statement

* refactor: apply suggestions from code review

Co-authored-by: dapineyro <[email protected]>

* style: move to proper folder

* style: update tests/test_clos/test_get_job_list.py

Co-authored-by: dapineyro <[email protected]>

Co-authored-by: dapineyro <[email protected]>
* fix error messages

* Bump version to v1.3.1

* correct pytests using BadRequestException
@danielboloc danielboloc marked this pull request as ready for review December 12, 2022 22:01
@danielboloc danielboloc changed the base branch from main to dev December 12, 2022 22:02
egenc and others added 8 commits December 13, 2022 09:20
* pytest for BadRequestException

* renamed function

* Apply suggestions from code review

Co-authored-by: Daniel Boloc <[email protected]>

* requested changes

* test moved to folder

Co-authored-by: Erdal Genc <[email protected]>
Co-authored-by: Daniel Boloc <[email protected]>
* pytest for function project_id

* script updated

* Apply suggestions from code review

Co-authored-by: dapineyro <[email protected]>

* module docstring added

* Update test_project_id.py

* requested changes

* Update tests/test_clos/test_project_id.py

Co-authored-by: dapineyro <[email protected]>

Co-authored-by: Erdal Genc <[email protected]>
Co-authored-by: dapineyro <[email protected]>
* proper json added

* pytest function added

* script updated for proper workflow name

* Apply suggestions from code review

Co-authored-by: dapineyro <[email protected]>

* Apply suggestions from code review

Co-authored-by: dapineyro <[email protected]>

* import added

* module docstring

* Update tests/test_clos/test_detect_workflow.py

Co-authored-by: dapineyro <[email protected]>

Co-authored-by: Erdal Genc <[email protected]>
Co-authored-by: dapineyro <[email protected]>
* pytest added for output workflow_id

* Object Class is modified to Job

* values are masked

* json update, assert update

* module docstring added

* Apply suggestions from code review

Co-authored-by: dapineyro <[email protected]>

* requested changes

Co-authored-by: Erdal Genc <[email protected]>
Co-authored-by: dapineyro <[email protected]>
* pytest added for output workflow_id

* Object Class is modified to Job

* values are masked

* json update, assert update

* module docstring added

* Apply suggestions from code review

Co-authored-by: dapineyro <[email protected]>

* requested changes

Co-authored-by: Erdal Genc <[email protected]>
Co-authored-by: dapineyro <[email protected]>
* Pytest for process_workflow_list added

* file moved to test_clos folder

* Apply suggestions from code review

Co-authored-by: Daniel Boloc <[email protected]>

* Apply suggestions from code review

Co-authored-by: dapineyro <[email protected]>

* updated functions

* Apply suggestions from code review

Co-authored-by: dapineyro <[email protected]>

* code improvement

* Update tests/test_clos/test_process_workflow_list.py

Co-authored-by: dapineyro <[email protected]>

* Update tests/test_clos/test_process_workflow_list.py

Co-authored-by: dapineyro <[email protected]>

Co-authored-by: Erdal Genc <[email protected]>
Co-authored-by: Daniel Boloc <[email protected]>
Co-authored-by: dapineyro <[email protected]>
* test: add tests for 'get_workflow_list' method

* refactor: apply suggestions from code review

Co-authored-by: dapineyro <[email protected]>

* test: update bad request code and workflows .json

* move test to proper folder

* style: remove comment line

* test: add workflows .json file

Co-authored-by: dapineyro <[email protected]>
Base automatically changed from dev to main May 5, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants