-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test: fetch_cloudos_id function #130
Open
danielboloc
wants to merge
25
commits into
main
Choose a base branch
from
test_fetch_cloudos_id
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(parameters): add parameter for customization. See #90 * docs: add documentation in changelog and readme * bump: increse minor version 1.0.0 to 1.1.0 * refactor: replace command line option from cromwell with constant variable * docs: update about request interval option * refactor: add control expression to not surpass wait time * refactor: change variable to the constant for Cromwell jobs
Co-authored-by: dapineyro <[email protected]>
Co-authored-by: dapineyro <[email protected]>
* Add new cost limit as default 30$ * CHANGELOG updated * VERSION updated * Update cloudos/__main__.py Co-authored-by: dapineyro <[email protected]> * version update * Update README.md * version bump to 1.2.1 Co-authored-by: Erdal Genc <[email protected]> Co-authored-by: dapineyro <[email protected]> Co-authored-by: Christina Chatzipantsiou <[email protected]> Co-authored-by: dapineyro <[email protected]>
* fix BadRequestException #84 * make wdl-importsfile optional * update docs * simplify code * simplify code 2 * simplify code 3 * simplify code 4 * small doc change * fix repo for projects * Update to prepare a release
* fix BadRequestException #84 * make wdl-importsfile optional * update docs * simplify code * simplify code 2 * simplify code 3 * simplify code 4 * small doc change * fix repo for projects * Use API key when no cromwell key is available * Adds click support * small help change * Updates docs * Minor doc changes
* Pytests added for _create_cromwell_header function * unused code removed * Apply suggestions from code review Co-authored-by: dapineyro <[email protected]> * new folder for cloudos tests * init Co-authored-by: Erdal Genc <[email protected]> Co-authored-by: dapineyro <[email protected]>
* test: add tests for 'get_job_list' * refactor: add new assert statement * refactor: apply suggestions from code review Co-authored-by: dapineyro <[email protected]> * style: move to proper folder * style: update tests/test_clos/test_get_job_list.py Co-authored-by: dapineyro <[email protected]> Co-authored-by: dapineyro <[email protected]>
* fix error messages * Bump version to v1.3.1 * correct pytests using BadRequestException
* pytest for BadRequestException * renamed function * Apply suggestions from code review Co-authored-by: Daniel Boloc <[email protected]> * requested changes * test moved to folder Co-authored-by: Erdal Genc <[email protected]> Co-authored-by: Daniel Boloc <[email protected]>
* pytest for function project_id * script updated * Apply suggestions from code review Co-authored-by: dapineyro <[email protected]> * module docstring added * Update test_project_id.py * requested changes * Update tests/test_clos/test_project_id.py Co-authored-by: dapineyro <[email protected]> Co-authored-by: Erdal Genc <[email protected]> Co-authored-by: dapineyro <[email protected]>
* proper json added * pytest function added * script updated for proper workflow name * Apply suggestions from code review Co-authored-by: dapineyro <[email protected]> * Apply suggestions from code review Co-authored-by: dapineyro <[email protected]> * import added * module docstring * Update tests/test_clos/test_detect_workflow.py Co-authored-by: dapineyro <[email protected]> Co-authored-by: Erdal Genc <[email protected]> Co-authored-by: dapineyro <[email protected]>
* pytest added for output workflow_id * Object Class is modified to Job * values are masked * json update, assert update * module docstring added * Apply suggestions from code review Co-authored-by: dapineyro <[email protected]> * requested changes Co-authored-by: Erdal Genc <[email protected]> Co-authored-by: dapineyro <[email protected]>
* pytest added for output workflow_id * Object Class is modified to Job * values are masked * json update, assert update * module docstring added * Apply suggestions from code review Co-authored-by: dapineyro <[email protected]> * requested changes Co-authored-by: Erdal Genc <[email protected]> Co-authored-by: dapineyro <[email protected]>
* Pytest for process_workflow_list added * file moved to test_clos folder * Apply suggestions from code review Co-authored-by: Daniel Boloc <[email protected]> * Apply suggestions from code review Co-authored-by: dapineyro <[email protected]> * updated functions * Apply suggestions from code review Co-authored-by: dapineyro <[email protected]> * code improvement * Update tests/test_clos/test_process_workflow_list.py Co-authored-by: dapineyro <[email protected]> * Update tests/test_clos/test_process_workflow_list.py Co-authored-by: dapineyro <[email protected]> Co-authored-by: Erdal Genc <[email protected]> Co-authored-by: Daniel Boloc <[email protected]> Co-authored-by: dapineyro <[email protected]>
* test: add tests for 'get_workflow_list' method * refactor: apply suggestions from code review Co-authored-by: dapineyro <[email protected]> * test: update bad request code and workflows .json * move test to proper folder * style: remove comment line * test: add workflows .json file Co-authored-by: dapineyro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Test
job.fetch_cloudos_id
functionPurpose
To create all tests considering all scenarios
Acceptance Criteria/Jira Ticket
CLOUDOSCLI-106
Changes
tests/test_jobs/test_fetch_cloudos_id.py
to test all scenariostests/test_data/jobs/fetch_cloudos_id.json
as mock dataTests