Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: reworked algorithm calculation of withdrawal frame validators #251

Merged
merged 5 commits into from
Sep 26, 2024
Merged

feat: reworked algorithm calculation of withdrawal frame validators #251

merged 5 commits into from
Sep 26, 2024

Conversation

Tarens2
Copy link
Contributor

@Tarens2 Tarens2 commented Sep 19, 2024 •
edited
Loading

Description

  • updated calculation validators withdraw time, now instead of default sweeping mean we calculate time based on index of validator

Checklist:

  • Checked the changes locally.
  • Created / updated analytics events.
  • Created / updated the technical documentation (README.md / docs / etc.).
  • Affects / requires changes in other services (Matomo / Sentry / CloudFlare / etc.).

@Tarens2 Tarens2 requested a review from a team as a code owner September 19, 2024 09:07
TheDZhon
TheDZhon requested changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@TheDZhon TheDZhon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪 Thanks for implementing this!

I believe the how-estimation-works.md file should include these changes, too.
Moreover, let's call it 'withdrawal sweep' here and there as it's a well-known term.

TheDZhon
TheDZhon approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Tarens2 Tarens2 merged commit 7471cae into develop Sep 26, 2024
5 checks passed
@Tarens2 Tarens2 deleted the feature/si-1575-update-calculation-time-for-validators-with-withdrawable branch September 26, 2024 08:14
@itaven itaven mentioned this pull request Sep 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiRaiks DiRaiks DiRaiks approved these changes

@TheDZhon TheDZhon TheDZhon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tarens2 @TheDZhon @DiRaiks