[UI-666] Integrate lido warehouse packages #82

solidovic · 2023-07-27T10:15:53Z

Description

Use https://github.com/lidofinance/warehouse packages

Testing notes

Needs full testing
Design compared to https://www.figma.com/file/pmtFrBp0z1RvzdfcHaV2fn/Widget-UI-Guide?type=design&node-id=5-2728&mode=design&t=quBOmbXZML1wbwv7-0

From develop to main

[CI] Switch WFs to critical

from develop to main

Develop -> main

Develop to Main

develop to main

…use-packages # Conflicts: # package.json # pages/_app.tsx # shared/api/withCsp.ts

Jabher · 2023-07-31T16:33:28Z

features/claim/claimFormDisconnected.tsx

@@ -18,7 +19,7 @@ export const ClaimFormDisconnected = () => {
          placeholder="0"
        />
      </InputGroupStyled>
-      <WalletConnect fullwidth />
+      <WalletConnectButton fullwidth />


Sad to say, but this should be renamed. Sorry for not seeing this earlier.
We should avoid confusion with WalletConnect.

Do you have suggests how to rename?

done.
https://github.com/lidofinance/warehouse/pull/159/commits/b1c5c6e436598a76519827993f5cddd4abe80752

WalletConnectButton ---> ConnectWalletButton

hexnickk4997

Looks good 👍 Just a few minor questions

hexnickk4997 · 2023-08-01T15:03:51Z

config/rpc.ts

@@ -1,4 +1,4 @@
-import { CHAINS } from 'config/chains';
+import { CHAINS } from '@lido-sdk/constants';


Let's not used lido-sdk chains, it's buggy regarding types

ok. but some code requires CHAINS from '@lido-sdk/constants', for example warehouse packages code.
How you suggest for avoid types problems (either satisfies operator or as operator or something else)

hexnickk4997 · 2023-08-01T15:05:15Z

features/aragon/aragonWallet.tsx

@@ -1,14 +1,17 @@
+import { useWeb3 } from 'reef-knot/web3-react';
+


Do you mind removing spaces? All codebase is without them 🤔

Yes, but wants some order in imports

Lets make it in next PR (because will be many change files) via https://github.com/azat-io/eslint-plugin-perfectionist

hexnickk4997 · 2023-08-01T15:05:53Z

features/claim/wallet.tsx

                  </TokensAmount>
                  &nbsp;
-                  <TokenToWallet address={token?.address} />
+                  <TokenToWallet address={token?.address || ''} />


Why can't it be undefined?

needs patch to TokenToWallet (warehouse)

hexnickk4997 · 2023-08-01T15:06:09Z

features/claim/wallet.tsx

-                    <FormatToken amount={unclaimed} symbol={token?.symbol} />
+                    <FormatToken
+                      amount={unclaimed}
+                      symbol={token?.symbol || ''}


Why can't it be undefined?

needs patch to FormatToken (warehouse)

hexnickk4997 · 2023-08-01T15:07:21Z

features/vesting/vestingDetailedSlide.tsx

@@ -125,14 +128,14 @@ export const VestingDetailedSlide: FC<VestingDetailedSlideProps> = memo(
            <Column $primary>
              <DetailsHeader>Available</DetailsHeader>
              <DetailsValue>
-                <FormatToken amount={unclaimed} symbol={token?.symbol} />
+                <FormatToken amount={unclaimed} symbol={token?.symbol || ''} />


Same here, it should allow to pass undefined

needs patch to FormatToken (warehouse)

hexnickk4997 · 2023-08-01T15:07:33Z

features/vesting/vestingSummarySlide.tsx

@@ -78,7 +81,7 @@ export const VestingSummarySlide: FC<VestingSummarySlideProps> = memo(
              <DetailsValue>
                <FormatToken
                  amount={unclaimed?.add(locked ?? BigNumber.from(0))}
-                  symbol={token?.symbol}
+                  symbol={token?.symbol || ''}


needs patch to FormatToken (warehouse)

pages/_app.tsx

hexnickk4997 · 2023-08-01T15:08:54Z

pages/_app.tsx

-      </AppWagmiConfig>
-
+const AppWrapper: FC<AppProps> = (props) => (
+  <NoSSRWrapper>


Why do we wrap the whole app into NoSSR?

because several troubles places in widget and in warehouse (possibly reef knot related)

Last time these errors were related to the connect button, but not the whole app. Can you double-check that the whole app isn't working, and we need to wrap it in NoSSRWrapper?

It wasn't much, but some info still was rendered

solidovic · 2023-08-02T12:18:55Z

after merge https://github.com/lidofinance/warehouse/pull/159 update :

@lidofinance/next-widget-layout
@lidofinance/eth-ui-wallet-modal
@lidofinance/eth-next-widget-app-evm
@lidofinance/eth-ui-primitives

hexnickk4997

Looks good, let's check if it's possible to not wrap the whole app in nossrwrapper and we are good to go

infoster42 and others added 14 commits May 3, 2023 19:11

Merge pull request #40 from lidofinance/develop

5662f73

From develop to main

Merge pull request #51 from lidofinance/develop

5c21727

From develop to main

Merge pull request #54 from lidofinance/develop

337ff40

From develop to main

Merge pull request #58 from lidofinance/develop

6c8f55d

[CI] Switch WFs to critical

Merge pull request #62 from lidofinance/develop

7f9b286

from develop to main

Merge pull request #66 from lidofinance/develop

d6e5a0b

from develop to main

Merge pull request #72 from lidofinance/develop

3a5dec0

Develop -> main

Merge pull request #75 from lidofinance/develop

4f5debc

Develop to Main

Merge pull request #79 from lidofinance/develop

972fda4

develop to main

Merge pull request #81 from lidofinance/develop

e5cf71d

develop to main

feat: update deps

b0028f2

feat: use wareouse layout

3eeaa37

feat: use eth-ui-wallet-modal from warehouse

bae216b

feat: use ui-primitives from warehouse

1206dd6

solidovic mentioned this pull request Jul 27, 2023

feat: use warehouse packages #42

Closed

solidovic marked this pull request as ready for review July 28, 2023 12:10

solidovic requested a review from a team as a code owner July 28, 2023 12:10

solidovic added 3 commits July 31, 2023 15:03

Merge remote-tracking branch 'origin/main' into integrate-lido-wareho…

a6b43c1

…use-packages # Conflicts: # package.json # pages/_app.tsx # shared/api/withCsp.ts

fix: types errors

4b0f7a0

refactor: codestyle

c29c7c5

solidovic requested review from Jabher and hexnickk4997 July 31, 2023 12:38

Jabher reviewed Jul 31, 2023

View reviewed changes

hexnickk4997 reviewed Aug 1, 2023

View reviewed changes

fix: env import for local development

826867e

solidovic changed the title ~~Integrate lido warehouse packages~~ [UI-666] Integrate lido warehouse packages Aug 14, 2023

solidovic added 3 commits August 15, 2023 23:46

refactor: use ConnectWalletButton instead WalletConnectButton

1b2df9e

refactor: use ConnectWalletButton instead WalletConnectButton

17c6afd

refactor: use ConnectWalletButton instead WalletConnectButton

8580fd4

solidovic added 3 commits August 16, 2023 00:06

refactor: use CHAINS from local

86fa262

refactor: not use fallback fo FormatToken and TokenToWallet

8221754

chore: update warehouse pkgs

93131f8

solidovic requested review from Jabher and hexnickk4997 August 31, 2023 12:49

hexnickk4997 reviewed Sep 4, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[UI-666] Integrate lido warehouse packages #82

[UI-666] Integrate lido warehouse packages #82

solidovic commented Jul 27, 2023 •

edited

Loading

Jabher Jul 31, 2023

solidovic Aug 3, 2023 •

edited

Loading

solidovic Aug 15, 2023

solidovic Aug 15, 2023

hexnickk4997 left a comment

hexnickk4997 Aug 1, 2023

solidovic Aug 3, 2023

solidovic Aug 15, 2023

hexnickk4997 Aug 1, 2023

solidovic Aug 3, 2023

solidovic Aug 15, 2023

hexnickk4997 Aug 1, 2023

solidovic Aug 3, 2023

solidovic Aug 15, 2023

hexnickk4997 Aug 1, 2023

solidovic Aug 3, 2023

solidovic Aug 15, 2023

hexnickk4997 Aug 1, 2023

solidovic Aug 3, 2023

solidovic Aug 15, 2023

hexnickk4997 Aug 1, 2023

solidovic Aug 3, 2023

solidovic Aug 15, 2023

hexnickk4997 Aug 1, 2023

solidovic Aug 3, 2023

hexnickk4997 Sep 4, 2023

hexnickk4997 Sep 4, 2023

solidovic commented Aug 2, 2023 •

edited

Loading

hexnickk4997 left a comment

		@@ -1,4 +1,4 @@
		import { CHAINS } from 'config/chains';
		import { CHAINS } from '@lido-sdk/constants';

		@@ -1,14 +1,17 @@
		import { useWeb3 } from 'reef-knot/web3-react';

[UI-666] Integrate lido warehouse packages #82

Are you sure you want to change the base?

[UI-666] Integrate lido warehouse packages #82

Conversation

solidovic commented Jul 27, 2023 • edited Loading

Description

Testing notes

Choose a reason for hiding this comment

solidovic Aug 3, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hexnickk4997 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

solidovic commented Aug 2, 2023 • edited Loading

hexnickk4997 left a comment

Choose a reason for hiding this comment

solidovic commented Jul 27, 2023 •

edited

Loading

solidovic Aug 3, 2023 •

edited

Loading

solidovic commented Aug 2, 2023 •

edited

Loading