Feat/alliance #252
Feat/alliance #252
Conversation
There was a problem hiding this comment.
Thank you for the work you've done on this! However, there are areas where the code could be cleaned up for better readability. Some of the redundant parts can be streamlined, and a few sections might benefit from refactoring. Once these adjustments are made, I believe the code will be in great shape.
scripts/vote_2024_10_01_holesky.py
Outdated
| @@ -0,0 +1,79 @@ | |||
| """ | |||
| Voting 01/10/2024! | |||
| Add ET setup for Alliance in stETH | |||
tests/test_2024_10_01_holesky.py
Outdated
| @@ -0,0 +1,226 @@ | |||
| """ | |||
| Tests for voting 01/10/2024 | |||
tests/test_2024_10_01_holesky.py
Outdated
|
|
||
| """ | ||
|
|
||
| from scripts.vote_2024_10_01_holesky import start_vote |
tests/test_2024_10_01_holesky.py
Outdated
|
|
||
| def test_vote(helpers, accounts, vote_ids_from_env, stranger, ldo_holder, bypass_events_decoding): | ||
| steth = contracts.lido | ||
| easy_track = contracts.easy_track |
There was a problem hiding this comment.
it's better to use addresses in tests than to use contracts
tests/test_2024_10_01_holesky.py
Outdated
| ldo_holder=ldo_holder, | ||
| dao_voting=contracts.voting, | ||
| ) | ||
| ''' |
There was a problem hiding this comment.
please, remove all commented sections
tests/test_2024_10_01_holesky.py
Outdated
|
|
||
| evm_script_factories_after = easy_track.getEVMScriptFactories() | ||
|
|
||
| # 1. Add TMC stETH top up EVM script factory address TBA (AllowedRecipientsRegistry address TBA) |
There was a problem hiding this comment.
and also please replace all TBA with addresses
tests/test_2024_10_01_holesky.py
Outdated
| ''' | ||
|
|
||
| # 2. Add TMC stables top up EVM script factory address TBA (AllowedRecipientsRegistry address TBA, AllowedTokensRegistry address TBA) | ||
| assert alliance_ops_top_up_evm_script_factory_new in evm_script_factories_after |
There was a problem hiding this comment.
do we really need to check it twice?
tests/test_2024_10_01_holesky.py
Outdated
| assert alliance_ops_top_up_evm_script_factory_new not in evm_script_factories_before | ||
|
|
||
| alliance_multisig_acc = accounts.at("xd4090CA1134F8dE1450B8246916F73d212efdEf6", force=True) # Testnet DAO Multisigs | ||
| alliance_dai_usdc_contract = accounts.at("0x2eb8e9198e647f80ccf62a5e291bcd4a5a3ca68c", force=True) # Testnet Stablecoins |
There was a problem hiding this comment.
it's rudiments from the previous launch connected with swaps.
We can't use these addresses here. you have to use alliance_multisig_acc as a receiver
tests/test_2024_10_01_holesky.py
Outdated
| ) | ||
|
|
||
|
|
||
| alliance_ops_allowed_recipients_registry = interface.AllowedRecipientRegistry( |
There was a problem hiding this comment.
it's better to declare variables in the beginning of tests
tests/test_2024_10_08_holesky.py
Outdated
| validate_evmscript_factory_removed_event, | ||
| ) | ||
| _ | ||
| # STETH_TRANSFER_MAX_DELTA = 2 |
voting script and tests for the next voting changed