Tests for Negative rebase feature

tests/acceptance/test_oracle_report_sanity_checker.py

@@ -17,6 +17,7 @@
     INACTIVITY_PENALTIES_AMOUNT_PWEI,
     CL_BALANCE_ORACLES_ERROR_UPPER_BP_LIMIT
 )
+from utils.test.helpers import ZERO_ADDRESS
 
 # Source of truth: https://hackmd.io/pdix1r4yR46fXUqiHaNKyw?view
 expected_report_limits = {
@@ -46,6 +47,9 @@ def test_links(contract):
 
 def test_limits(contract):
     assert contract.getMaxPositiveTokenRebase() == expected_report_limits["maxPositiveTokenRebase"]
-    limits =  contract.getOracleReportLimits()
+    limits = contract.getOracleReportLimits()
 
     assert dict(zip(expected_report_limits.keys(), limits)) == expected_report_limits
+
+def test_second_opinion_is_empty(contract):
+    assert contract.secondOpinionOracle() == ZERO_ADDRESS

tests/regression/test_neg_rebase_sanity_checks.py

@@ -0,0 +1,113 @@
+import pytest
+from brownie import Contract, web3, reverts, accounts, chain  # type: ignore
+from utils.evm_script import encode_error
+from utils.test.exit_bus_data import LidoValidator
+from utils.test.extra_data import ExtraDataService
+from utils.test.oracle_report_helpers import (
+    oracle_report,
+)
+
+from utils.test.helpers import ETH
+from utils.config import (
+    contracts,
+)
+
+INITIAL_SLASHING_AMOUNT_PWEI = 1000
+INACTIVITY_PENALTIES_AMOUNT_PWEI = 101
+ONE_PWEI = ETH(0.001)
+
+@pytest.fixture(scope="module")
+def oracle_report_sanity_checker() -> Contract:
+    return contracts.oracle_report_sanity_checker
+
+
+def test_negative_rebase_correct_exited_validators_count_pos_rebase(oracle_report_sanity_checker):
+    locator = contracts.lido_locator
+    assert oracle_report_sanity_checker.address == locator.oracleReportSanityChecker()
+
+    reported_validators = exited_validators_count()
+
+    reported_validators_values = [value + 2 for value in reported_validators.values()]
+    oracle_report(cl_diff=ETH(300), stakingModuleIdsWithNewlyExitedValidators=list(reported_validators.keys()),
+                   numExitedValidatorsByStakingModule=reported_validators_values)
+
+    count = oracle_report_sanity_checker.getReportDataCount()
+    assert count > 0
+    (_, stored_exited_validators, _) = oracle_report_sanity_checker.reportData(count - 1)
+
+    assert stored_exited_validators == sum(reported_validators_values)
+
+def test_negative_rebase_correct_exited_validators_count_neg_rebase(oracle_report_sanity_checker):
+    locator = contracts.lido_locator
+    assert oracle_report_sanity_checker.address == locator.oracleReportSanityChecker()
+
+    reported_validators = exited_validators_count()
+
+    reported_validators_values = [value + 3 for value in reported_validators.values()]
+    oracle_report(cl_diff=-ETH(40000), stakingModuleIdsWithNewlyExitedValidators=list(reported_validators.keys()),
+                   numExitedValidatorsByStakingModule=reported_validators_values)
+
+    count = oracle_report_sanity_checker.getReportDataCount()
+    assert count > 0
+    (_, stored_exited_validators, _) = oracle_report_sanity_checker.reportData(count - 1)
+
+    assert stored_exited_validators == sum(reported_validators_values)
+
+def test_negative_rebase_correct_balance_neg_rebase(oracle_report_sanity_checker):
+    locator = contracts.lido_locator
+    assert oracle_report_sanity_checker.address == locator.oracleReportSanityChecker()
+
+    cl_decrease = ETH(40000)
+    oracle_report(cl_diff=-cl_decrease, exclude_vaults_balances=True)
+
+    count = oracle_report_sanity_checker.getReportDataCount()
+    assert count > 0
+    (_, _, cl_balance) = oracle_report_sanity_checker.reportData(count - 1)
+    assert cl_balance == cl_decrease
+
+    cl_decrease2 = ETH(30000)
+    oracle_report(cl_diff=-cl_decrease2, exclude_vaults_balances=True)
+    count = oracle_report_sanity_checker.getReportDataCount()
+    assert count > 0
+    (_, _, cl_balance) = oracle_report_sanity_checker.reportData(count - 1)
+
+    assert cl_balance == cl_decrease2
+
+
+def test_blocked_huge_negative_rebase(oracle_report_sanity_checker):
+    locator = contracts.lido_locator
+    assert oracle_report_sanity_checker.address == locator.oracleReportSanityChecker()
+
+    (_, cl_validators, cl_balance) = contracts.lido.getBeaconStat()
+
+    max_cl_balance = (INITIAL_SLASHING_AMOUNT_PWEI + INACTIVITY_PENALTIES_AMOUNT_PWEI) * ONE_PWEI * cl_validators
+    error_cl_decrease = cl_balance // 10    # 10% of current balance will lead to error
+    print("max_cl_balance", max_cl_balance)
+    with reverts(encode_error("IncorrectCLBalanceDecrease(uint256, uint256)", [error_cl_decrease, max_cl_balance])):
+        oracle_report(cl_diff=-error_cl_decrease, exclude_vaults_balances=True, silent=True)
+
+def test_negative_rebase_more_than_54_reports(oracle_report_sanity_checker):
+    locator = contracts.lido_locator
+    assert oracle_report_sanity_checker.address == locator.oracleReportSanityChecker()
+
+    reported_validators_values = exited_validators_count().values()
+    for _ in range(58):
+        reported_validators_values = [value + 3 for value in reported_validators_values]
+        oracle_report(cl_diff=-ETH(400), stakingModuleIdsWithNewlyExitedValidators=exited_validators_count().keys(),
+                       numExitedValidatorsByStakingModule=reported_validators_values)
+
+    count = oracle_report_sanity_checker.getReportDataCount()
+    assert count > 0
+    (_, stored_exited_validators, _) = oracle_report_sanity_checker.reportData(count - 1)
+
+    assert stored_exited_validators == sum(reported_validators_values)
+
+
+def exited_validators_count():
+    assert contracts.lido_locator.stakingRouter() == contracts.staking_router
+    ids = contracts.staking_router.getStakingModuleIds()
+    exited = {}
+    for id in ids:
+        exited[id] = contracts.staking_router.getStakingModule(id)["exitedValidatorsCount"]
+
+    return exited