chore: review fixes

lidofinance · Apr 24, 2024 · f39dabf · f39dabf
1 parent ffbb200
commit f39dabf
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 20 deletions.
diff --git a/README.md b/README.md
@@ -99,13 +99,6 @@ In a typical weekly omnibus workflow, you need only `mainnet-fork` and
 `mainnet` networks. In case of large test campaign on Lido upgrades,
 it also could be useful to go with `holesky` and `holesky-fork` testnets first.
 
-> [!IMPORTANT]
-> **Holesky specifics.**
-> Due to Holesky not being supported by Infura yet, setting RPC URL for Holesky is different. Instead of setting `WEB3_INFURA_PROJECT_ID` env variable set `HOLESKY_RPC_URL`.
->
-> **Sepolia specifics.**
-> Due to Sepolia not being supported by Infura yet, setting RPC URL for Holesky is different. Instead of setting `WEB3_INFURA_PROJECT_ID` env variable set `SEPOLIA_RPC_URL`.
-
 > [!WARNING]
 > **Holesky is partially supported.**
 > At the moment not all parameters are set in `configs/config_holesky.py` and acceptance/regression/snapshot tests are not operational.

diff --git a/network-config.yaml b/network-config.yaml
@@ -3,7 +3,7 @@ live:
     networks:
       - chainid: 17000
         explorer: https://api-holesky.etherscan.io/api
-        host: $HOLESKY_RPC_URL
+        host: https://holesky.infura.io/v3/$WEB3_INFURA_PROJECT_ID
         id: holesky
         # New backward-compatible multicall contract. multicall2 is missing on Holesky. See https://github.com/mds1/multicall
         multicall2: "0xcA11bde05977b3631167028862bE2a173976CA11"
@@ -14,7 +14,7 @@ live:
     networks:
       - chainid: 11155111
         explorer: https://api-sepolia.etherscan.io/api
-        host: $SEPOLIA_RPC_URL
+        host: https://sepolia.infura.io/v3/$WEB3_INFURA_PROJECT_ID
         id: sepolia
         # New backward-compatible multicall contract. multicall2 is missing on Sepolia.
         # So multicall3 (backward compatible) is used. See https://github.com/mds1/multicall
@@ -24,7 +24,6 @@ live:
 
 development:
 
-  # Mainnet Fork
   - cmd: ./ganache.sh
     cmd_settings:
       accounts: 10
@@ -39,7 +38,6 @@ development:
     # https://github.com/mds1/multicall#multicall2-contract-addresses
     multicall2: "0x5BA1e12693Dc8F9c48aAD8770482f4739bEeD696"
 
-  # Goerli Fork
   - cmd: ./ganache.sh
     cmd_settings:
       accounts: 10
@@ -50,38 +48,35 @@ development:
       port: 8545
     host: http://127.0.0.1
     id: goerli-fork
-    name: goerli-fork
+    name: Ganache-CLI (Goerli Fork)
     timeout: 360
 
-  # Holesky Fork
   - cmd: ./ganache.sh
     cmd_settings:
       accounts: 10
       chain_id: 17000
-      fork: $HOLESKY_RPC_URL
+      fork: holesky
       gas_limit: 30000000
       mnemonic: brownie
       port: 8545
     host: http://127.0.0.1
     id: holesky-fork
-    name: holesky-fork
+    name: Ganache-CLI (Holesky Fork)
     timeout: 360
 
-  # Sepolia Fork
   - cmd: ./ganache.sh
     cmd_settings:
       accounts: 10
       chain_id: 11155111
-      fork: $SEPOLIA_RPC_URL
+      fork: sepolia
       gas_limit: 30000000
       mnemonic: brownie
       port: 8545
     host: http://127.0.0.1
     id: sepolia-fork
-    name: sepolia-fork
+    name: Ganache-CLI (Sepolia Fork)
     timeout: 360
 
-  # Local Fork
   - cmd: ./ganache.sh
     cmd_settings:
       accounts: 10
@@ -92,7 +87,7 @@ development:
       port: 8545
     host: http://127.0.0.1
     id: local-fork
-    name: local-fork
+    name: Ganache-CLI (Local Fork)
     explorer: https://api.etherscan.io/api
     timeout: 360
     # https://github.com/mds1/multicall#multicall2-contract-addresses