New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ledger derivation path UI #85

Merged

alx-khramov merged 18 commits into main from feature/ledger-derivation-path

Oct 23, 2023

Contributor

alx-khramov commented Sep 19, 2023 •

edited

Loading

Resolves UI-94.
Also see UI-888 for additional research.

This PR updates Ledger device connection process.
The Ledger device is still connected directly with a browser via USB connection. Ledger Live is not involved in the connection.
There is new UI (see the screenshot below), which:

Shows the new screen with connection instructions.
Allows choosing between 2 derivation paths templates (Ledger Live and Ledger Legacy). Other paths can be added later.
Allows choosing between first 20 accounts derived from the chosen derivation path (4 pages with 5 accounts each). We can add more pages, but 20 seems enough for now. Loading the page takes ~ 5 seconds.
Handles errors.

alx-khramov added 5 commits

September 20, 2023 02:02


          feat(ledger-connector): load path from ls

1f29894


          feat(connect-wallet-modal): add ledger derivation path ui

68c5f5d


          fix(demo-react): theme select behavior

00b3200


          fix: update eslint packages as a partial fix

06d2f54


          chore: yarn.lock

f4f2025

alx-khramov requested a review from Jabher

September 19, 2023 23:24

alx-khramov self-assigned this

changeset-bot bot commented Sep 19, 2023 •

edited

Loading

⚠️ No Changeset found

Latest commit: 4064481

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

alx-khramov had a problem deploying to preview

September 19, 2023 23:24

— with

GitHub Actions Failure

Jabher reviewed

View reviewed changes

apps/demo-react/pages/index.tsx Outdated Show resolved Hide resolved

Jabher reviewed

View reviewed changes

packages/connect-wallet-modal/src/components/Ledger/LedgerAccountButton.tsx Show resolved Hide resolved

Jabher reviewed

View reviewed changes

packages/connect-wallet-modal/src/components/Ledger/LedgerAccountButton.tsx Outdated Show resolved Hide resolved

Jabher reviewed

View reviewed changes

packages/connect-wallet-modal/src/components/Ledger/LedgerAccountButton.tsx Outdated Show resolved Hide resolved

Jabher reviewed

View reviewed changes

packages/connect-wallet-modal/src/components/Ledger/LedgerAccountScreen.tsx Outdated Show resolved Hide resolved

Jabher reviewed

View reviewed changes

packages/connect-wallet-modal/src/components/Ledger/LedgerAccountScreen.tsx Outdated Show resolved Hide resolved

Jabher reviewed

View reviewed changes

packages/connect-wallet-modal/src/components/Ledger/LedgerAccountScreen.tsx Outdated Show resolved Hide resolved

Jabher reviewed

View reviewed changes

packages/connect-wallet-modal/src/components/Ledger/LedgerAccountScreen.tsx Outdated Show resolved Hide resolved

Jabher reviewed

View reviewed changes

packages/connect-wallet-modal/src/components/Ledger/LedgerConnectionScreen.tsx Show resolved Hide resolved

Jabher reviewed

View reviewed changes

packages/connect-wallet-modal/src/components/Ledger/LedgerContext.tsx Outdated Show resolved Hide resolved

Jabher reviewed

View reviewed changes

packages/connect-wallet-modal/src/components/Ledger/LedgerContext.tsx Outdated Show resolved Hide resolved

Jabher reviewed

View reviewed changes

packages/connect-wallet-modal/src/components/Ledger/LedgerModal.tsx Outdated Show resolved Hide resolved

Jabher reviewed

View reviewed changes

packages/connect-wallet-modal/src/components/Ledger/helpers.ts Outdated Show resolved Hide resolved

Jabher reviewed

View reviewed changes

packages/connect-wallet-modal/src/components/Ledger/helpers.ts Outdated Show resolved Hide resolved

Jabher reviewed

View reviewed changes

packages/connect-wallet-modal/src/components/Ledger/helpers.ts Outdated Show resolved Hide resolved

Jabher reviewed

View reviewed changes

packages/connect-wallet-modal/src/components/Ledger/hooks.ts Outdated Show resolved Hide resolved

Jabher reviewed

View reviewed changes

packages/connect-wallet-modal/src/components/Ledger/hooks.ts Outdated Show resolved Hide resolved

Jabher reviewed

View reviewed changes

packages/connect-wallet-modal/src/components/Ledger/helpers.ts Show resolved Hide resolved

alx-khramov added 2 commits

September 21, 2023 13:27


          fix(demo-react): eslint errors

a80719e


          fix: issues found during review

e77ffe7

alx-khramov temporarily deployed to preview

September 21, 2023 11:50

— with

GitHub Actions Inactive

alx-khramov requested a review from Jabher

September 21, 2023 11:51

Jabher reviewed

View reviewed changes

apps/demo-react/components/contractTesting/Stake.tsx Show resolved Hide resolved

Jabher reviewed

View reviewed changes

apps/demo-react/hooks/useClaimSelection.ts Outdated Show resolved Hide resolved

Jabher reviewed

View reviewed changes

packages/connect-wallet-modal/src/components/Ledger/LedgerAccountButton.tsx Outdated Show resolved Hide resolved

Jabher reviewed

View reviewed changes

packages/connect-wallet-modal/src/components/Ledger/LedgerAccountScreen.tsx Outdated Show resolved Hide resolved

Jabher previously approved these changes

View reviewed changes

alx-khramov added 2 commits

September 26, 2023 23:46


          refactor: getAccountRecords, more try-catch

11ee0ca


          refactor: SkeletonWrapper gradient

bf38684

alx-khramov dismissed Jabher’s stale review via

bf38684

September 26, 2023 20:46


          Merge branch 'main' into feature/ledger-derivation-path

73d8cf3

alx-khramov temporarily deployed to preview

September 26, 2023 20:49

— with

GitHub Actions Inactive

alx-khramov added 4 commits

October 9, 2023 15:52


          fix(ledger-connector): create new provider for each activate call

4721ae6


          fix(ledger-connector): connector.isSupported check

48ee25f


          fix(ledger-connector): unexpected endless useEffect cycle

8b73771


          feat(ledger-connector): improve error catching

080d9f9

AnnaSila temporarily deployed to preview

October 10, 2023 12:30

— with

GitHub Actions Inactive


          fix: don't show connection screen after AccountButton click

cdbf238

AnnaSila temporarily deployed to preview

October 12, 2023 10:49

— with

GitHub Actions Inactive

alx-khramov added 2 commits

October 20, 2023 18:47


          Merge branch 'main' into feature/ledger-derivation-path

780b95f

# Conflicts:
#	package.json
#	packages/connect-wallet-modal/src/components/WalletsModal/types.ts
#	packages/connectors/ledger-connector/src/hid/connector.ts
#	yarn.lock


          chore: reef-knot v1.10.0

9fda835

alx-khramov requested review from Jabher and hexnickk4997

October 20, 2023 16:22


          refactor: deduplicate interceptLedgerError, handle LockedDeviceError …

…in autoconnect too

hexnickk4997 approved these changes

View reviewed changes

packages/connect-wallet-modal/src/components/Ledger/LedgerAccountScreen.tsx Show resolved Hide resolved

hexnickk4997 reviewed

View reviewed changes

packages/connect-wallet-modal/package.json Show resolved Hide resolved

alx-khramov merged commit a2d60c8 into main

alx-khramov deleted the feature/ledger-derivation-path branch

October 23, 2023 11:36

alx-khramov mentioned this pull request

Fix lint errors #93

Merged

alx-khramov mentioned this pull request

Ledger connection UI rework lidofinance/ethereum-staking-widget#120

Merged

4 tasks

alx-khramov mentioned this pull request

Update reef-knot to 1.10.5 lidofinance/trp-ui#88

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet