Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: ledgerService import #67

Merged
merged 2 commits into from
Jul 7, 2023
Merged

Fix: ledgerService import #67

merged 2 commits into from
Jul 7, 2023

Conversation

alx-khramov
Copy link
Contributor

Fixes the issue: TypeError: _ledgerhq_hw_app_eth_lib_services_ledger__WEBPACK_IMPORTED_MODULE_2__.resolveTransaction is not a function
The issue could happen in runtime in a project, which uses the reef-knot package.
The reason of the issue: ledgerService wasn't imported properly, named import fixes it.

Fixes the "ledgerService.resolveTransaction is not a function" issue because ledgerService wasn't imported properly.
@alx-khramov alx-khramov requested a review from Jeday July 7, 2023 12:46
@alx-khramov alx-khramov self-assigned this Jul 7, 2023
@changeset-bot
Copy link

changeset-bot bot commented Jul 7, 2023

⚠️ No Changeset found

Latest commit: b828fb6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@alx-khramov alx-khramov temporarily deployed to preview July 7, 2023 12:46 — with GitHub Actions Inactive
@alx-khramov alx-khramov merged commit a86b4c7 into main Jul 7, 2023
1 check passed
@alx-khramov alx-khramov deleted the fix/ledgerservice-import branch July 7, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants