Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ledgerhq libraries into reef-knot #62

Merged
merged 4 commits into from
Jul 4, 2023
Merged

Move ledgerhq libraries into reef-knot #62

merged 4 commits into from
Jul 4, 2023

Conversation

alx-khramov
Copy link
Contributor

@alx-khramov alx-khramov commented Jun 29, 2023 •
edited
Loading

Changes

  1. The code is moved to Reef Knot from (closes UI-89):

The connectors are now stored in single @reef-knot/ledger-connector package

  1. Pass supportedChainIds to LedgerHQFrameConnector following this:
    feat: allow passing supportedChainIds ledgerhq-frame-connector#11

@alx-khramov alx-khramov self-assigned this Jun 29, 2023
@changeset-bot
Copy link

changeset-bot bot commented Jun 29, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: d92eac2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@alx-khramov alx-khramov temporarily deployed to preview June 29, 2023 14:07 — with GitHub Actions Inactive
This was referenced Jun 29, 2023
Merged
Closed
Jeday
Jeday previously approved these changes Jul 3, 2023
View reviewed changes
@alx-khramov alx-khramov mentioned this pull request Jul 3, 2023
Merged
Jabher
Jabher previously approved these changes Jul 3, 2023
View reviewed changes
@alx-khramov alx-khramov dismissed stale reviews from Jabher and Jeday via d92eac2 July 3, 2023 18:07
@alx-khramov alx-khramov temporarily deployed to preview July 3, 2023 18:07 — with GitHub Actions Inactive
@alx-khramov alx-khramov requested a review from Jabher July 3, 2023 18:11
@alx-khramov alx-khramov merged commit fba2ce6 into main Jul 4, 2023
@alx-khramov alx-khramov deleted the feature/ui-89-move-ledgerhq-libraries-into-reef-knot branch July 4, 2023 09:31
@alx-khramov alx-khramov mentioned this pull request Jul 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeday Jeday Jeday approved these changes

@hexnickk4997 hexnickk4997 Awaiting requested review from hexnickk4997

@Jabher Jabher Awaiting requested review from Jabher

Assignees

@alx-khramov alx-khramov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alx-khramov @Jabher @Jeday