Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create getDefaultConfig function #177

Merged

Conversation

manneredboor
Copy link
Contributor

@manneredboor manneredboor commented Sep 30, 2024

The function can be called inside or outside of React components.
The function will contain some initializers (etc. wagmi’s createConfig).

const { wagmiConfig, reefKnotConfig, walletsModalConfig } = getDefaultConfig({
  rpc,
  chains,
  autoConnect,
  metrics,
  walletsShown,
  walletsPinned,
  linkTerms: 'lido.fi/terms-of-use',
  linkPrivacyNotice: 'lido.fi/privacy-notice',
  ...otherReefKnotProps,
})

Copy link

changeset-bot bot commented Sep 30, 2024

⚠️ No Changeset found

Latest commit: 16b647c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@manneredboor manneredboor changed the title WIP: Feature/si 1589 create getdefaultconfig function Create getDefaultConfig function Oct 3, 2024
@manneredboor manneredboor marked this pull request as ready for review October 3, 2024 11:42
@manneredboor manneredboor requested a review from a team as a code owner October 3, 2024 11:42
Copy link
Contributor

@alx-khramov alx-khramov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see the thoughtfulness you put into refactoring this code — this is a great job.
And I have a few comments which I want to discuss before approving.

@alx-khramov alx-khramov self-requested a review October 8, 2024 09:44
@manneredboor manneredboor merged commit 9200761 into develop Oct 8, 2024
@manneredboor manneredboor deleted the feature/si-1589-create-getdefaultconfig-function branch October 8, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants