Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect wallet modal ui update #130

Merged
merged 16 commits into from
Apr 1, 2024

Conversation

manneredboor
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Mar 18, 2024

⚠️ No Changeset found

Latest commit: 43da4b4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@manneredboor manneredboor marked this pull request as ready for review March 19, 2024 11:06
@manneredboor manneredboor requested a review from a team as a code owner March 19, 2024 11:06
Copy link
Contributor

@alx-khramov alx-khramov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Wanted to deploy the branch via GitHub Pages, but there are some linting issues, so it is not deployed. See: https://github.com/lidofinance/reef-knot/actions/runs/8344994411
  2. There are no changesets or version bumps in the PR, so the changes won't be released

Copy link
Contributor

@alx-khramov alx-khramov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing hiddenWallets is a breaking change, so I think we need to release a new major version of reef-knot here.
Also, I like the changes regarding the wallet adapters ids. But it means that adapters versions must be bumped too, though it is a minor change.

apps/demo-react/components/WalletsModal.tsx Outdated Show resolved Hide resolved
packages/connect-wallet-modal/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@alx-khramov alx-khramov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alx-khramov
alx-khramov previously approved these changes Mar 25, 2024
…etter compatibility with walletconnect based wallets
@manneredboor manneredboor merged commit 17f84b3 into main Apr 1, 2024
1 check passed
@manneredboor manneredboor deleted the feature/si-1268-new-modal-for-widgets branch April 1, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants