-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connect wallet modal ui update #130
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Wanted to deploy the branch via GitHub Pages, but there are some linting issues, so it is not deployed. See: https://github.com/lidofinance/reef-knot/actions/runs/8344994411
- There are no changesets or version bumps in the PR, so the changes won't be released
...ct-wallet-modal/src/components/WalletsModal/components/ConnectWalletModal/sortWalletsList.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing hiddenWallets
is a breaking change, so I think we need to release a new major version of reef-knot
here.
Also, I like the changes regarding the wallet adapters ids. But it means that adapters versions must be bumped too, though it is a minor change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checks are still not passing: https://github.com/lidofinance/reef-knot/actions/runs/8378716677/job/22943935608#step:6:73
…etter compatibility with walletconnect based wallets
No description provided.