-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: sanity checker for network config #279
base: develop
Are you sure you want to change the base?
Commits on Jun 6, 2024
-
feat: sanity checker for network config
Implement a sanity checker that checks that the information stored in the DB corresponds the chain for which the app is run. If the app is run for one chain, and the DB contains data for another chain, the sanity checker prevents the app from start and throws the error.
Configuration menu - View commit details
-
Copy full SHA for 774e97f - Browse repository at this point
Copy the full SHA 774e97fView commit details
Commits on Jun 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 69af272 - Browse repository at this point
Copy the full SHA 69af272View commit details -
refactor: rename
findOneById
methodRename the `findOneById` method of the `SRModuleStorageService` to `findOneByModuleId`.
Configuration menu - View commit details
-
Copy full SHA for f6051f0 - Browse repository at this point
Copy the full SHA f6051f0View commit details
Commits on Jun 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 23c807b - Browse repository at this point
Copy the full SHA 23c807bView commit details
Commits on Jun 11, 2024
-
refactor: replace constants with module addresses
Replace the internal `CURATED_MODULE_ADDRESSES_FOR_CHAINS` constant with curated module addresses with the appropriate `REGISTRY_CONTRACT_ADDRESSES` constant from `@lido-nestjs` repo.
Configuration menu - View commit details
-
Copy full SHA for ef7d2d3 - Browse repository at this point
Copy the full SHA ef7d2d3View commit details -
refactor: fix lint errors in tests
Remove unnecessary `consensusProviderService` variable and fix lint errors in unit tests for `NetworkValidation` service.
Configuration menu - View commit details
-
Copy full SHA for ed54f90 - Browse repository at this point
Copy the full SHA ed54f90View commit details
Commits on Jun 17, 2024
-
refactor: move network ID checking
Move checking that the network ID specified in .env config matches the EL chain ID one level up in the `validate` method of the `NetworkValidation` service.
Configuration menu - View commit details
-
Copy full SHA for 4a6c3ca - Browse repository at this point
Copy the full SHA 4a6c3caView commit details -
refactor: new
checkChainIdMismatch
methodMove checking that chain ID from the config, EL chain ID and CL chain ID match each other to the separate `checkChainIdMismatch` private method of the `NetworkValidation` service.
Configuration menu - View commit details
-
Copy full SHA for 529f2f8 - Browse repository at this point
Copy the full SHA 529f2f8View commit details -
refactor: new specific error types
Add two new custom error types (`ChainMismatchError` and `InconsistentDataInDBError`) with properties that help better indicate specific of the error. Update test cases to make sure that correct error types with correct properties are returned in each test case.
Configuration menu - View commit details
-
Copy full SHA for 407dabe - Browse repository at this point
Copy the full SHA 407dabeView commit details -
Rename `dbKey` local constant to `dbKeys`; Rename `dbOperator` local constant to `dbOperators`.
Configuration menu - View commit details
-
Copy full SHA for 7016a00 - Browse repository at this point
Copy the full SHA 7016a00View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a08698 - Browse repository at this point
Copy the full SHA 9a08698View commit details
Commits on Jun 18, 2024
-
chore: add new specific error types
Add new specific error types for cases when keys or operators table is empty. Change error messages to better reflect the essence of the error. Add new tests for testing these new error types.
Configuration menu - View commit details
-
Copy full SHA for a194a83 - Browse repository at this point
Copy the full SHA a194a83View commit details -
fix: test for chain and EL IDs mismatch
Fix test that tests the case when chain ID and EL ID don't match each other. This test should not depend on the value of the `VALIDATOR_REGISTRY_ENABLE` env variable.
Configuration menu - View commit details
-
Copy full SHA for 8c04d2f - Browse repository at this point
Copy the full SHA 8c04d2fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8bf17bf - Browse repository at this point
Copy the full SHA 8bf17bfView commit details -
Configuration menu - View commit details
-
Copy full SHA for be0b2d6 - Browse repository at this point
Copy the full SHA be0b2d6View commit details