Module id validation and operators e2e tests #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddort
approved these changes
Sep 10, 2023
…n' into feat/val-189-readme-fix
Co-authored-by: Raman Siamionau <[email protected]>
…at/val-189-readme-fix
avsetsin
reviewed
Sep 18, 2023
src/http/sr-modules-operators-keys/sr-modules-operators-keys.service.ts
Outdated
Show resolved
Hide resolved
src/http/sr-modules-validators/sr-modules-validators.service.ts
Outdated
Show resolved
Hide resolved
| }); | ||
| }); | ||
|
|
||
| describe('The /modules/:module_id/operators/:operator_id', () => { |
There was a problem hiding this comment.
do we have a test to get data by module address?
There was a problem hiding this comment.
added /* eslint-disable @typescript-eslint/no-unused-vars */
because of
lass KeysRegistryServiceMock {
async update(moduleAddress, blockHash) {
return;
}
}
There was a problem hiding this comment.
I meant that we have tests for module.id but not for module.address, although both scenarios are supported in the code
There was a problem hiding this comment.
confused conversation , sorry
added test yesterday for moduleAddress
…' into feat/val-275-validators-endpoint-e2e
…oint-e2e E2E SRModulesValidatorsController
…stors-keys-e2e E2E SRModuleOperatorsKeys
…nterfaces' into feat/val-189-module-id-validation
…n' into feat/val-275-sr-modules-keys-e2e
avsetsin
approved these changes
Sep 19, 2023
Improvements after review
…-e2e E2E SRModulesKeys controller
Amuhar
merged commit 376cc88
into
feat/val-189-remove-extra-keys-interfaces
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.