Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deploy script to include SepoliaDepositAdapter contract upgrade #824

Merged
merged 3 commits into from
Feb 21, 2024

Conversation

vp4242
Copy link
Member

@vp4242 vp4242 commented Feb 21, 2024

Update deploy script to include SepoliaDepositAdapter contract upgrade

Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 Scarcely am I sure if we need to hardcode the addresses here instead of putting/reading them from the deployed-sepolia.json

wdyt, @arwer13?

@arwer13
Copy link
Contributor

arwer13 commented Feb 21, 2024

@TheDZhon @vp42ldo There is updateProxyImplementation from deploy.js for the case (if the adapter implementation not deployed yet). It will read the proxy address from the state file, deploy the implementation, bind it to the proxy and update the impl address in the state file.

@vp4242
Copy link
Member Author

vp4242 commented Feb 21, 2024

@TheDZhon @vp42ldo There is updateProxyImplementation from deploy.js for the case (if the adapter implementation not deployed yet). It will read the proxy address from the state file, deploy the implementation, bind it to the proxy and update the impl address in the state file.

There is an issue with updateProxyImplementation. DepositContractAdapter and it's proxy are not part of deployed-.json as it's specific for Sepolia-deploy only. Currently there is no reference to the proxy address except a parameter to stakingRouter

@arwer13
Copy link
Contributor

arwer13 commented Feb 21, 2024

Oh, we've forgotten to add it to the state file :/ I'd propose to add it now under /depositContractAdapter. It is part of the setup and thus must be presented in the state file as well.

@TheDZhon
Copy link
Contributor

Having it would be prudent, I agree with @arwer13 🙏

@vp4242 vp4242 marked this pull request as ready for review February 21, 2024 15:44
@vp4242 vp4242 requested a review from arwer13 February 21, 2024 15:53
Copy link
Contributor

@arwer13 arwer13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, taking into account the deploy script is most likely one-time-usage and the migration to the new core repo and typescript (won't move it there)

@vp4242 vp4242 merged commit 942546e into develop Feb 21, 2024
6 checks passed
@TheDZhon TheDZhon deleted the sepolia-deposit-adapter-upgrade branch February 21, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants