-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sepolia deployment and deposit contract adapter #820
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vp4242
changed the title
Debug/sepolia deposit contract adapter
Sepolia deployment and deposit contract adapter
Feb 1, 2024
Comment on lines
+8
to
+27
contract SepoliaDepositAdapter { | ||
|
||
uint public constant TEST_VALUE = 16; | ||
address public immutable depositContract; | ||
|
||
function deposit( | ||
bytes calldata pubkey, | ||
bytes calldata withdrawal_credentials, | ||
bytes calldata signature, | ||
bytes32 deposit_data_root | ||
) external payable { | ||
} | ||
|
||
constructor(address _deposit_contract) { | ||
depositContract = _deposit_contract; | ||
} | ||
|
||
|
||
|
||
} |
Check warning
Code scanning / Slither
Contracts that lock Ether Medium
Contract locking ether found:
Contract SepoliaDepositAdapter has payable functions:
- SepoliaDepositAdapter.deposit(bytes,bytes,bytes,bytes32)
But does not have a function to withdraw the ether
Contract SepoliaDepositAdapter has payable functions:
- SepoliaDepositAdapter.deposit(bytes,bytes,bytes,bytes32)
But does not have a function to withdraw the ether
grstepanov
approved these changes
Feb 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
arwer13
approved these changes
Feb 7, 2024
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Sepolia deployment scripts.
Adds deposit contract adapter (empty via proxy).