Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sepolia deployment and deposit contract adapter #820

Merged
merged 17 commits into from
Feb 7, 2024

Conversation

vp4242
Copy link
Member

@vp4242 vp4242 commented Feb 1, 2024

Adds Sepolia deployment scripts.
Adds deposit contract adapter (empty via proxy).

@vp4242 vp4242 marked this pull request as draft February 1, 2024 13:36
@TheDZhon TheDZhon changed the base branch from master to develop February 1, 2024 13:37
@vp4242 vp4242 changed the title Debug/sepolia deposit contract adapter Sepolia deployment and deposit contract adapter Feb 1, 2024
Comment on lines +8 to +27
contract SepoliaDepositAdapter {

uint public constant TEST_VALUE = 16;
address public immutable depositContract;

function deposit(
bytes calldata pubkey,
bytes calldata withdrawal_credentials,
bytes calldata signature,
bytes32 deposit_data_root
) external payable {
}

constructor(address _deposit_contract) {
depositContract = _deposit_contract;
}



}

Check warning

Code scanning / Slither

Contracts that lock Ether Medium

Contract locking ether found:
Contract SepoliaDepositAdapter has payable functions:
- SepoliaDepositAdapter.deposit(bytes,bytes,bytes,bytes32)
But does not have a function to withdraw the ether
Copy link
Contributor

@grstepanov grstepanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@arwer13 arwer13 marked this pull request as ready for review February 7, 2024 10:45
@arwer13 arwer13 self-requested a review February 7, 2024 10:45
@vp4242
Copy link
Member Author

vp4242 commented Feb 7, 2024

LGTM

@arwer13 arwer13 merged commit a6a9a5c into develop Feb 7, 2024
5 of 6 checks passed
@arwer13 arwer13 deleted the debug/sepolia-deposit-contract-adapter branch February 7, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants