Sync master with develop

.github/workflows/analyse.yml

@@ -14,14 +14,14 @@ jobs:
       security-events: write
     steps:
       - name: Checkout repository
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           persist-credentials: false
 
       - name: Setup node.js version
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
-          node-version: 16
+          node-version: 18
 
       - name: Get yarn cache directory path
         id: yarn-cache-dir-path
@@ -57,7 +57,7 @@ jobs:
         run: >
           curl -sSL https://install.python-poetry.org | python - &&
           poetry install --no-root
-      
+
       - name: Remove foundry.toml
         run: rm -f foundry.toml
 

.github/workflows/assert-bytecode.yml

@@ -2,23 +2,22 @@ name: Verify deployed contracts' bytecode
 
 on:
   pull_request:
-    branches:
-      - 'master'
+    branches: [master]
 
 jobs:
   assert-bytecode:
     name: Assert deployed contracts bytecode
     runs-on: ubuntu-latest
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           persist-credentials: false
 
       - name: Setup node.js version
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
-          node-version: 16
+          node-version: 18
 
       - name: Get yarn cache directory path
         id: yarn-cache-dir-path
@@ -49,6 +48,9 @@ jobs:
       - name: Compile contracts
         run: yarn compile
 
+      - name: Write config for action-verify-bytecode
+        run: yarn extract-artifacts
+
       - name: Verify bytecode
         uses: lidofinance/action-verify-bytecode@master
         with:
@@ -64,5 +66,5 @@ jobs:
           cat _actual _expected | sort | uniq -u | tee _diff
           [ -s _diff ] && exit 1 || exit 0
         env:
-          IGNORE_REGEX: test|lib|mock|interface|template|OrderedCallback|Pausable|Versioned|BeaconChainDepositor|PausableUntil
+          IGNORE_REGEX: test|lib|mock|interface|template|OrderedCallback|Pausable|Versioned|BeaconChainDepositor|PausableUntil|WithdrawalsManagerProxy|WithdrawalsManagerStub|ERC1967Proxy
         if: ${{ always() }}

.github/workflows/fix-abi-pr.yml

@@ -9,14 +9,14 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           persist-credentials: false
 
       - name: Setup node.js version
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
-          node-version: 16
+          node-version: 18
 
       - name: Get yarn cache directory path
         id: yarn-cache-dir-path

.github/workflows/linters.yml

@@ -8,14 +8,14 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           persist-credentials: false
 
       - name: Setup node.js version
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
-          node-version: 16
+          node-version: 18
 
       - name: Get yarn cache directory path
         id: yarn-cache-dir-path
@@ -57,14 +57,14 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           persist-credentials: false
 
       - name: Setup node.js version
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
-          node-version: 16
+          node-version: 18
 
       - name: Get yarn cache directory path
         id: yarn-cache-dir-path

.github/workflows/release-abis.yml

@@ -0,0 +1,61 @@
+---
+name: Upload ABIs to a published release
+
+on:
+  release:
+    types: [published] # stable and pre-releases
+
+permissions:
+  contents: write
+
+jobs:
+  release-abis:
+    name: Build ABIs and upload to the release
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          persist-credentials: false
+
+      - name: Setup node.js version
+        uses: actions/setup-node@v4
+        with:
+          node-version: 18
+
+      - name: Get yarn cache directory path
+        id: yarn-cache-dir-path
+        run: echo "dir=$(yarn config get cacheFolder)" >> "$GITHUB_OUTPUT"
+
+      - name: Cache yarn cache
+        id: cache-yarn-cache
+        uses: actions/cache@v3
+        with:
+          path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
+          key: yarn-${{ hashFiles('**/yarn.lock') }}
+          restore-keys: yarn-${{ hashFiles('**/yarn.lock') }}
+
+      - name: Cache node_modules
+        id: cache-node-modules
+        uses: actions/cache@v3
+        with:
+          path: '**/node_modules'
+          key: node_modules-${{ hashFiles('**/yarn.lock') }}
+          restore-keys: node_modules-${{ hashFiles('**/yarn.lock') }}
+
+      - name: Install modules
+        run: yarn
+        if: |
+          steps.cache-yarn-cache.outputs.cache-hit != 'true' ||
+          steps.cache-node-modules.outputs.cache-hit != 'true'
+
+      - name: Compile contracts
+        run: yarn compile
+
+      - name: Make an ABIs archive
+        run: zip -j abis.zip lib/abi/*.json
+
+      - name: Upload the archive to the release
+        run: |
+          gh release view "$GITHUB_REF" || exit;
+          gh release upload "$GITHUB_REF" abis.zip;

.github/workflows/scratch-deploy-local.yml

@@ -0,0 +1,55 @@
+name: Scratch deploy on local clean anvil
+
+on:
+  pull_request:
+    branches: [master, develop]
+
+jobs:
+  do-scratch-deploy:
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          persist-credentials: false
+
+      - name: Install Foundry
+        uses: foundry-rs/foundry-toolchain@v1
+
+      - name: Start anvil in background
+        # For the port see port in scripts/scratch/dao-local-deploy.sh in RPC_URL env var
+        run: anvil -p 8555 --mnemonic "test test test test test test test test test test test junk" &
+
+      - name: Setup node.js version
+        uses: actions/setup-node@v4
+        with:
+          node-version: 18
+
+      - name: Get yarn cache directory path
+        id: yarn-cache-dir-path
+        run: echo "dir=$(yarn config get cacheFolder)" >> $GITHUB_OUTPUT
+
+      - name: Cache yarn cache
+        id: cache-yarn-cache
+        uses: actions/cache@v3
+        with:
+          path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
+          key: yarn-${{ hashFiles('**/yarn.lock') }}
+          restore-keys: yarn-${{ hashFiles('**/yarn.lock') }}
+
+      - name: Cache node_modules
+        id: cache-node-modules
+        uses: actions/cache@v3
+        with:
+          path: '**/node_modules'
+          key: node_modules-${{ hashFiles('**/yarn.lock') }}
+          restore-keys: node_modules-${{ hashFiles('**/yarn.lock') }}
+
+      - name: Install modules
+        run: yarn
+        if: |
+          steps.cache-yarn-cache.outputs.cache-hit != 'true' ||
+          steps.cache-node-modules.outputs.cache-hit != 'true'
+
+      - name: Run local deploy script
+        run: bash scripts/scratch/dao-local-deploy.sh

.github/workflows/storage-layout-check.yml

@@ -12,12 +12,12 @@ jobs:
     name: Assert storage layout
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Setup node.js version
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
-          node-version: 16.x
+          node-version: 18.x
           cache: 'yarn'
 
       - name: Submodules
@@ -32,3 +32,4 @@ jobs:
           mode: check
           src-folder: ./contracts
           ignore-folders: '{test_helpers,template,mocks}'
+          ignore-contracts: 'WithdrawalsManagerProxy|WithdrawalsManagerStub|ERC1967Proxy'

.github/workflows/storage-layout-update.yml

@@ -9,12 +9,12 @@ jobs:
     name: Update storage layout
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Setup node.js version
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
-          node-version: 16.x
+          node-version: 18.x
           cache: 'yarn'
 
       - name: Install yarn deps

.gitignore

@@ -42,6 +42,8 @@ cli/vendor
 # e2e temp data
 /deployed-e2e.json
 
+/deployed-local.json
+
 # OS relative
 .DS_Store