Merge-ready protocol service pack 📦 #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new event logs account addr, amount and shares amount.
Sometimes we should user shares transfers instead of token transfers to avoid rounding issues. Introduce function and new `TransferShares` event. Note: also emits conventional `Transfer` event for the compatibility with existing indexing off-chain solutions subscribed to transfers.
Add tests on transfer itself and on the logging `Transfer` and `TransferShares` events.
to make less difficult to track used keys
`transfer` and `transferShares` methods should emit same events sequence: - Transfer - TransferShares.
Interface file should contain all events definitions.
It is a controversary decision. Friday devteam sync planned for the resolution.
Fix COMMENTS from MixBytes audit of DepositSecurityModule
refactor: rename withdrawal limit points to withdrawal limit for consistency
arwer13
commented
May 17, 2022
Psirex
reviewed
May 18, 2022
TheDZhon
changed the title
|
Folks, thank you all for the reviews and fixes! I really appreciate your help and suggestions! |
arwer13
commented
May 18, 2022
Add more meaningful API for staking limits Rename STAKING_PAUSE_ROLE to STAKING_CONTROL_ROLE [skip ci] Tests needs to be updated
update stake limit tests
Fix: review/mev lips round2
|
Here we are, just have merged all the changes from the previous review round 🏁 |
arwer13
commented
May 18, 2022
| * @notice Allows the contract to receive ETH | ||
| * @dev execution layer rewards may be sent as plain ETH transfers | ||
| */ | ||
| receive() external payable { |
There was a problem hiding this comment.
NB: gas cost of receive with the event is 22111 (see tx on goerli). The cost w/o event was 21055
Rename STAKE_LIMIT_POSITION to STAKING_STATE_POSITION. Remove extra comma. Better comments for the `distributeFee` func.
Feat: Add changes for the 3rd review round
|
Let's move on 🚀 |
RayLvv
pushed a commit
to okx-dao/lido-dao
that referenced
this pull request
Dec 12, 2022
Merge-ready protocol service pack 📦
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📦 Merge-ready protocol service pack
There is an implementation for the following Lido improvement proposals:
Context