Merge-ready protocol service pack 📦 #401

The new event logs account addr, amount and shares amount.

Sometimes we should user shares transfers instead of token transfers to avoid rounding issues. Introduce function and new `TransferShares` event. Note: also emits conventional `Transfer` event for the compatibility with existing indexing off-chain solutions subscribed to transfers.

Add tests on transfer itself and on the logging `Transfer` and `TransferShares` events.

to make less difficult to track used keys

`transfer` and `transferShares` methods should emit same events sequence: - Transfer - TransferShares.

Interface file should contain all events definitions.

It is a controversary decision. Friday devteam sync planned for the resolution.

Fix COMMENTS from MixBytes audit of DepositSecurityModule

- make MevTxFeeVault payable - refactor a few names - add more clarifying comments

Scenario covers various mev/tx rewards and beacon chain rewards/losses.

- refactor - add separate role for setting vault's address to Lido - use Rewards Emulator in all tests

- rename `pushRewards` to `handleOracleReport` - 23-vote-mev-upgrade.js: fixes and Oracle deployment - update addresses of deployed contracts

- restore initialize() function which performs up-to-date initialization from scratch - keep the latest increment initialize function: namely dummy upgrade from v1 to v3 to correct version number - still a few TODOs left

- make separate private _initialize_v3 - rename public initialize_v3 to finalizeUpgrade_v3 - fix: make initialize() external

This reverts commit 68800ff.

Utilize MAX_MEMBERS constant properly with the `LidoOracle.addOracleMember` code.

Add transferERC721ToVault function for the `Lido` contract. Introduce the `RecoverERC721ToVault` event. Add tests to cover new code.

Disambiguate burn event name (`StETHBurnt` -> `SharesBurnt`). Update tests.

Enforce node operators limit programatically. Add tests.

Stich beacon report callbacks with ERC165 checks.

Fixing MixBytes audit findings

Add submits break feature to temporary close staking for new customers in case of entry queue massive demands.

Limit the contact's interface. Remove ERC721 recovery.

Sounds more reasonable and consistent.

Fix rewards distribution calculations if vault set to zero.

Remove extra vars and funcs to minimize Lido.sol contract's size

Rename STAKING_RATE_LIMIT_ROLE to STAKING_RESUME_ROLE. Remove obsolete SafeMath for uint64. Use ether amount nominated in wei (change memory layour).

Use suggestions and insights by Sam. K, Eugene P. and Alexey P.: - pass limit increase per block instead of duration; - introduce bit twiddling library; - add external viewers to integrate with frontend. Tests are need to be updated.

modifiers are too costly

More internal helpers inside StakeLimitUtils. Docs updated with actual behavior. Add some require statements. Improve test coverage.

Since we have adopted `_auth` function there are some more space to settle previously removed code features.

Kiln

Feat: add staking soft rate limit

add tests for stake limit library

Move require statements inside the library. Update tests, giveup the absolute blocks numbering.

fix: enforce stake limit invariants by the lib

Leverage OZ safeTransfer helper lib which deals with non-conformant tokens (USDT, for example).

uint256 for every interface whenever applicable instead of uint96 and uint32.

Add the `getCurrentStakeLimit` method. Add the `getStakeLimitFullInfo` method.

Review/mev lips round1

Make rate limit libs more handy and meaningful. NB: disable stake-limit unit tests for now.

Update the terms everywhere.

Feat: Review/mev lips fixes

Fox: stake limit corner cases

…istency

They are misleading from the off-chain perspective.

refactor: rename withdrawal limit points to withdrawal limit for consistency

Add more meaningful API for staking limits Rename STAKING_PAUSE_ROLE to STAKING_CONTROL_ROLE [skip ci] Tests needs to be updated

update stake limit tests

Fix: review/mev lips round2

Rename STAKE_LIMIT_POSITION to STAKING_STATE_POSITION. Remove extra comma. Better comments for the `distributeFee` func.

Feat: Add changes for the 3rd review round

Commits on Mar 31, 2022

feat: deploy kiln

avsetsin committed Mar 31, 2022

Configuration menu

View commit details

Copy full SHA for 0d0b2c7

Browse repository at this point

Copy the full SHA

0d0b2c7 View commit details

Browse the repository at this point in the history

Merge-ready protocol service pack 📦 #401

Merge-ready protocol service pack 📦 #401

Commits on Dec 18, 2021

Commits on Dec 30, 2021

Commits on Jan 9, 2022

Commits on Jan 10, 2022

Commits on Jan 12, 2022

Commits on Jan 18, 2022

Commits on Jan 19, 2022

Commits on Jan 21, 2022

Commits on Jan 22, 2022

Commits on Jan 26, 2022

Commits on Jan 30, 2022

Commits on Jan 31, 2022

Commits on Feb 2, 2022

Commits on Feb 21, 2022

Commits on Feb 22, 2022

Commits on Feb 23, 2022

Commits on Feb 28, 2022

Commits on Mar 31, 2022

Commits on Apr 4, 2022

Commits on Apr 13, 2022

Commits on Apr 14, 2022

Commits on Apr 16, 2022

Commits on Apr 17, 2022

Commits on Apr 18, 2022

Commits on Apr 19, 2022

Commits on Apr 20, 2022

Commits on Apr 21, 2022

Commits on Apr 25, 2022

Commits on May 11, 2022

Commits on May 13, 2022

Commits on May 14, 2022

Commits on May 15, 2022

Commits on May 16, 2022

Commits on May 17, 2022

Commits on May 18, 2022

Commits on May 19, 2022