Skip to content

Commit

Permalink
Add explanation why different solc used #86
Browse files Browse the repository at this point in the history
  • Loading branch information
ongrid committed Oct 25, 2020
1 parent 5cbc5a3 commit 0aa6044
Show file tree
Hide file tree
Showing 7 changed files with 26 additions and 23 deletions.
1 change: 1 addition & 0 deletions contracts/0.4.24/DePool.sol
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* See contracts/COMPILERS.md */
pragma solidity 0.4.24;

import "@aragon/os/contracts/apps/AragonApp.sol";
Expand Down
1 change: 1 addition & 0 deletions contracts/0.4.24/StETH.sol
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* See contracts/COMPILERS.md */
pragma solidity 0.4.24;

import "@aragon/os/contracts/apps/AragonApp.sol";
Expand Down
1 change: 1 addition & 0 deletions contracts/0.4.24/oracle/DePoolOracle.sol
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* See contracts/COMPILERS.md */
pragma solidity 0.4.24;

import "@aragon/os/contracts/apps/AragonApp.sol";
Expand Down
1 change: 1 addition & 0 deletions contracts/0.4.24/sps/StakingProvidersRegistry.sol
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* See contracts/COMPILERS.md */
pragma solidity 0.4.24;

import "@aragon/os/contracts/apps/AragonApp.sol";
Expand Down
3 changes: 2 additions & 1 deletion contracts/0.6.12/CstETH.sol
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
pragma solidity 0.6.12; // latest available for using OZ
/* See contracts/COMPILERS.md */
pragma solidity 0.6.12;

import "@openzeppelin/contracts/token/ERC20/ERC20.sol";
import "@openzeppelin/contracts/token/ERC20/ERC20Burnable.sol";
Expand Down
20 changes: 20 additions & 0 deletions contracts/COMPILERS.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
# Why we use different compilers

For DePool project coordination, governance and funds management we use [Aragon](https://aragon.org/dao), a well-developed and proven DAO Framework. The current stable release of its Kernel, [4.4.0](https://github.com/aragon/aragonOS/tree/v4.4.0) is fixed on the specific compiler version - [solc 0.4.24](https://solidity.readthedocs.io/en/v0.4.24/), that is currently outdated. Keeping security and consistency in mind, we decided to stay on an older yet proven combination - for all the contracts under Aragon management (`DePool`, `stETH`, `DePoolOracle`) we use solc 0.4.24 release.

cstETH token, that acts as autonomous wrapper and not governed by Aragon, was inherited from OpenZeppelin's library, using one of its stable releases [3.1.0](https://github.com/OpenZeppelin/openzeppelin-contracts/releases/tag/v3.1.0).

# How to compile

Separately:

```bash
yarn compile:4
yarn compile:6
```

All at once:

```bash
yarn compile
```
22 changes: 0 additions & 22 deletions contracts/README.md

This file was deleted.

0 comments on commit 0aa6044

Please sign in to comment.