feat: add KEYS_API_URL configuration #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lets add info about this configurations in README? |
Amuhar
reviewed
Sep 13, 2024
| KEYS_API_HOST = ''; | ||
|
|
||
| @ValidateIf((conf) => { | ||
| return !conf.KEYS_API_PORT && !conf.KEYS_API_HOST; |
There was a problem hiding this comment.
so we want to use KEYS_API_URL only if both conf.KEYS_API_PORT and conf.KEYS_API_HOST were not set, right ?
Amuhar
reviewed
Sep 13, 2024
| ); | ||
| toHaveProblemWithRecords(['KEYS_API_HOST'], validationErrors); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
maybe we also need test 'KEYS_API_URL, KEYS_API_HOST, KEYS_API_PORT are set'
|
lgtm, good work |
Amuhar
approved these changes
Sep 13, 2024
infloop
approved these changes
Sep 14, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.