-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: deposit-registry wip #233
Merged
eddort
merged 39 commits into
fix/val-1200-keys-events-fetch-impr
from
feat/refactor-deposit-cache
Sep 11, 2024
Merged
feat: deposit-registry wip #233
eddort
merged 39 commits into
fix/val-1200-keys-events-fetch-impr
from
feat/refactor-deposit-cache
Sep 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Amuhar
reviewed
Sep 3, 2024
src/contracts/deposits-registry/sanity-checker/integrity-checker/deposit-tree/deposit-tree.ts
Show resolved
Hide resolved
Amuhar
reviewed
Sep 3, 2024
Amuhar
reviewed
Sep 3, 2024
src/contracts/deposits-registry/sanity-checker/sanity-checker.service.ts
Show resolved
Hide resolved
src/contracts/deposits-registry/sanity-checker/sanity-checker.service.ts
Outdated
Show resolved
Hide resolved
src/contracts/deposits-registry/sanity-checker/sanity-checker.service.ts
Show resolved
Hide resolved
Amuhar
reviewed
Sep 3, 2024
Amuhar
reviewed
Sep 3, 2024
Amuhar
reviewed
Sep 10, 2024
Amuhar
reviewed
Sep 10, 2024
Amuhar
reviewed
Sep 10, 2024
Amuhar
reviewed
Sep 10, 2024
Amuhar
reviewed
Sep 10, 2024
Amuhar
reviewed
Sep 11, 2024
src/contracts/deposits-registry/sanity-checker/integrity-checker/integrity-checker.service.ts
Show resolved
Hide resolved
Amuhar
reviewed
Sep 11, 2024
src/contracts/deposits-registry/sanity-checker/integrity-checker/integrity-checker.service.ts
Show resolved
Hide resolved
Amuhar
reviewed
Sep 11, 2024
src/contracts/deposits-registry/sanity-checker/integrity-checker/integrity-checker.service.ts
Show resolved
Hide resolved
Amuhar
reviewed
Sep 11, 2024
src/contracts/deposits-registry/sanity-checker/integrity-checker/integrity-checker.service.ts
Show resolved
Hide resolved
Amuhar
reviewed
Sep 11, 2024
Amuhar
reviewed
Sep 11, 2024
src/contracts/deposits-registry/sanity-checker/integrity-checker/deposit-tree/deposit-tree.ts
Show resolved
Hide resolved
Amuhar
approved these changes
Sep 11, 2024
eddort
changed the base branch from
develop
to
fix/val-1200-keys-events-fetch-impr
September 11, 2024 15:17
…finance/lido-council-daemon into feat/refactor-deposit-cache-merge
…merge Feat/refactor deposit cache merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed
Changed
SanityChecker
, which now encompasses the validation logic.updateEventsCache
):depositRoot
from the local state with each chunk of events received, aiding in troubleshooting potential cache issues.depositRoot
now logs an error without throwing an exception if there is a mismatch.getAllDepositedEvents
):verifyFreshEvents
post-fetch to verify the integrity of new events; errors do not throw exceptions but return a flag, which is checked before attempting deposits.Refactored