-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support changing Effective Balance by config. #227
base: develop
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -277,6 +277,14 @@ export class EnvironmentVariables { | |
|
||
@IsEnum(WorkingMode) | ||
public WORKING_MODE = WorkingMode.Finalized; | ||
|
||
/** | ||
* Effective balance. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's add a few words about the purpose. For example, |
||
*/ | ||
@IsNumber() | ||
@Min(32) | ||
@Transform(({ value }) => parseInt(value, 10), { toClassOnly: true }) | ||
public EFFECTIVE_BALANCE_INCREMENTS = 32; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sorry for misleading you. Let's think about naming this var more concretely. For example, There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please, don't forget to add this var to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What do you think to use |
||
} | ||
|
||
export function validate(config: Record<string, unknown>) { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say that it is not worth logging. This parameter affects only one particular part of the application while the rest described above are more general