Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: future setup for support other l2 #533

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

feat: future setup for support other l2 #533

wants to merge 4 commits into from

Conversation

solidovic
Copy link
Contributor

@solidovic solidovic commented Oct 31, 2024 •
edited
Loading

Description

  • refactor(wrap/unwrap): preparing FAQ for other networks
  • refactor(etherscan): helpers

Checklist:

  • Checked the changes locally.
  • Created / updated analytics events.
  • Created / updated the technical documentation (README.md / docs / etc.).
  • Affects / requires changes in other services (Matomo / Sentry / CloudFlare / etc.).

@solidovic solidovic changed the base branch from develop to feature/si-1641-refactoring-single-source-of-truth-for-chainid-and-rpc October 31, 2024 11:28
@solidovic solidovic changed the title [WIP] feat: future setup for support other l2 feat: future setup for support other l2 Oct 31, 2024
@solidovic solidovic marked this pull request as ready for review October 31, 2024 13:25
@solidovic solidovic requested review from a team as code owners October 31, 2024 13:25
@preview-stands
Copy link

preview-stands bot commented Oct 31, 2024 •
edited
Loading

Preview stand status

Stand was demolished

Jeday
Jeday requested changes Nov 1, 2024
View reviewed changes
utils/etherscan.ts Outdated Show resolved Hide resolved
features/wsteth/shared/wrap-faq/wrap-faq.tsx Outdated Show resolved Hide resolved
shared/components/tx-link-etherscan/tx-link-etherscan.tsx Show resolved Hide resolved
@solidovic solidovic requested a review from Jeday November 1, 2024 13:17
Base automatically changed from feature/si-1641-refactoring-single-source-of-truth-for-chainid-and-rpc to develop November 4, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeday Jeday Jeday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@solidovic @Jeday