[WIP] Switch chain button #396
Conversation
…atest-stable-version-2' into feature/si-1310-unsupported-chain-banner-rework # Conflicts: # package.json # yarn.lock
…rework Signed-off-by: Anton Shalimov <[email protected]>
…rework Signed-off-by: Anton Shalimov <[email protected]>
Preview stand statusStand was demolished |
| background: #ffffff1a; | ||
|
|
||
| &:not(:disabled):hover { | ||
| // TODO |
There was a problem hiding this comment.
we are waiting the design updates
| }, [defaultChain]); | ||
|
|
||
| const chainName = useMemo(() => { | ||
| return Object.keys(L2_CHAINS)[ |
There was a problem hiding this comment.
Use object.entries to find by value and return key
There was a problem hiding this comment.
Actually consider just reversing key and values in L2_CHAINS
There was a problem hiding this comment.
No. If you are L2_CHAINS only to find keys by value you must reverse object.
| import { useAccount } from 'wagmi'; | ||
| import { useUserConfig } from 'config/user-config'; | ||
|
|
||
| export const useIsConnectedWalletAndSupportedChain = () => { |
There was a problem hiding this comment.
Too long hook name, maybe useSupportedChainActive
There was a problem hiding this comment.
A too-long hook name is not always bad.
TheuseSupportedChainActive isn't clearly.
There was a problem hiding this comment.
IMO it bloats code and impacts readbility, let's consider joint hook
| export const SubmitButton = () => { | ||
| const { active } = useWeb3(); | ||
| const { isConnected } = useAccount(); | ||
| const isSupportedChain = useIsSupportedChain(); |
There was a problem hiding this comment.
What if we combine all chain and account hooks into one?
There was a problem hiding this comment.
isConnected // for just wallet connection to show or not connect button
isSupportedChain // to show UnsupportedChainButton
isChainL2 // inside UnsupportedChainButton
isActiveWallet -> isDappActive // to know that we can use our dapp features like stake
There was a problem hiding this comment.
good idea, let's leave it for refactoring (when we remove useWeb3)
| Mainnet = 1, | ||
| Goerli = 5, | ||
| Holesky = 17000, | ||
| } | ||
|
|
||
| export enum L2_CHAINS { |
Description
Switch chain (to defaultChainId) button on wallet fallback.
merge after #371
Demo
Testing notes
Check all wallets;
Button use
defaultChainIdvar.Checklist: