Merge pull request #358 from lidofinance/feature/si-1287-remove-color…

…-for-visited-links [fix] link visited and warning
lidofinance · Jun 19, 2024 · defab9a · defab9a
2 parents fcf4e6c + 3f6d7ec
commit defab9a
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 14 deletions.
diff --git a/next.config.mjs b/next.config.mjs
@@ -58,6 +58,7 @@ export default withBundleAnalyzer({
     // https://github.com/vercel/next.js/blob/v12.3.4/packages/next/build/webpack-config.ts#L417
     // Presumably, it is true by default in next v13 and won't be needed
     esmExternals: true,
+    newNextLinkBehavior: true,
   },
   webpack(config) {
     config.module.rules.push(

diff --git a/shared/components/layout/header/components/navigation/styles.tsx b/shared/components/layout/header/components/navigation/styles.tsx
@@ -60,16 +60,11 @@ export const NavLink = styled.span<{ active: boolean }>`
   letter-spacing: 0.04em;
   opacity: ${(props) => (props.active ? 1 : 0.8)};
 
-  :hover {
+  &:hover {
     opacity: 1;
     color: var(--lido-color-secondary);
   }
 
-  // TODO: Not actual - remove
-  :visited {
-    color: var(--lido-color-secondary);
-  }
-
   svg {
     fill: ${({ active }) =>
       active ? `var(--lido-color-primary)` : `var(--lido-color-secondary)`};

diff --git a/shared/components/local-link/index.tsx b/shared/components/local-link/index.tsx
@@ -23,14 +23,13 @@ export const LocalLink: FC<PropsWithChildren<LinkProps>> = (props) => {
     }
 
     return (
-      <Link {...restProps} href={{ pathname: href, query: extraQuery }}>
-        {/* TODO: fix when go to Next v13+ */}
-        {/* see: https://nextjs.org/docs/app/building-your-application/upgrading/app-router-migration#link-component */}
-        {/* eslint-disable-next-line jsx-a11y/anchor-has-content,jsx-a11y/click-events-have-key-events,jsx-a11y/no-static-element-interactions */}
-        <a {...restProps} />
-      </Link>
+      <Link
+        {...restProps}
+        legacyBehavior={false}
+        href={{ pathname: href, query: extraQuery }}
+      />
     );
   }
 
-  throw new Error('Prop href is not compatible');
+  throw new Error('Prop href as object is not compatible');
 };
diff --git a/styles/global.ts b/styles/global.ts
@@ -36,7 +36,7 @@ const GlobalStyle = createGlobalStyle`
     color: var(--lido-color-primary);
 
     &:visited {
-      color: var(--lido-color-primaryVisited);
+      color: var(--lido-color-primary);
     }
 
     &:hover {