fix: partially change memory params to calldata

lidofinance · Oct 24, 2023 · dc03baa · dc03baa
1 parent f4efe8e
commit dc03baa
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 21 deletions.
diff --git a/contracts/AllowedRecipientsBuilder.sol b/contracts/AllowedRecipientsBuilder.sol
@@ -36,17 +36,17 @@ interface IRemoveAllowedRecipient {
 interface IAllowedRecipientsFactory {
     function deployAllowedRecipientsRegistry(
         address _admin,
-        address[] memory _addRecipientToAllowedListRoleHolders,
-        address[] memory _removeRecipientFromAllowedListRoleHolders,
-        address[] memory _setLimitParametersRoleHolders,
-        address[] memory _updateSpentAmountRoleHolders,
+        address[] calldata _addRecipientToAllowedListRoleHolders,
+        address[] calldata _removeRecipientFromAllowedListRoleHolders,
+        address[] calldata _setLimitParametersRoleHolders,
+        address[] calldata _updateSpentAmountRoleHolders,
         address bokkyPooBahsDateTimeContract
     ) external returns (IAllowedRecipientsRegistry);
 
     function deployAllowedTokensRegistry(
         address _defaultAdmin,
-        address[] memory _addTokensToAllowedListRoleHolders,
-        address[] memory _removeTokensFromAllowedListRoleHolders
+        address[] calldata _addTokensToAllowedListRoleHolders,
+        address[] calldata _removeTokensFromAllowedListRoleHolders
     ) external returns (IAllowedTokensRegistry registry);
 
     function deployTopUpAllowedRecipients(
@@ -260,9 +260,9 @@ contract AllowedRecipientsBuilder {
         address _trustedCaller,
         uint256 _limit,
         uint256 _periodDurationMonths,
-        address[] memory _tokens,
-        address[] memory _recipients,
-        string[] memory _titles,
+        address[] calldata _tokens,
+        address[] calldata _recipients,
+        string[] calldata _titles,
         uint256 _spentAmount
     ) public {
         IAllowedRecipientsRegistry allowedRecipientsRegistry =
@@ -278,8 +278,8 @@ contract AllowedRecipientsBuilder {
 
     function deploySingleRecipientTopUpOnlySetup(
         address _recipient,
-        string memory _title,
-        address[] memory _tokens,
+        string calldata _title,
+        address[] calldata _tokens,
         uint256 _limit,
         uint256 _periodDurationMonths,
         uint256 _spentAmount

diff --git a/contracts/AllowedRecipientsFactory.sol b/contracts/AllowedRecipientsFactory.sol
@@ -57,10 +57,10 @@ contract AllowedRecipientsFactory {
 
     function deployAllowedRecipientsRegistry(
         address _defaultAdmin,
-        address[] memory _addRecipientToAllowedListRoleHolders,
-        address[] memory _removeRecipientFromAllowedListRoleHolders,
-        address[] memory _setLimitParametersRoleHolders,
-        address[] memory _updateSpentAmountRoleHolders,
+        address[] calldata _addRecipientToAllowedListRoleHolders,
+        address[] calldata _removeRecipientFromAllowedListRoleHolders,
+        address[] calldata _setLimitParametersRoleHolders,
+        address[] calldata _updateSpentAmountRoleHolders,
         IBokkyPooBahsDateTimeContract _bokkyPooBahsDateTimeContract
     ) external returns (AllowedRecipientsRegistry registry) {
         registry = new AllowedRecipientsRegistry(
@@ -86,8 +86,8 @@ contract AllowedRecipientsFactory {
 
     function deployAllowedTokensRegistry(
         address _defaultAdmin,
-        address[] memory _addTokensToAllowedListRoleHolders,
-        address[] memory _removeTokensFromAllowedListRoleHolders
+        address[] calldata _addTokensToAllowedListRoleHolders,
+        address[] calldata _removeTokensFromAllowedListRoleHolders
     ) external returns (AllowedTokensRegistry registry) {
         registry = new AllowedTokensRegistry(
             _defaultAdmin,

diff --git a/contracts/EVMScriptFactories/TopUpAllowedRecipients.sol b/contracts/EVMScriptFactories/TopUpAllowedRecipients.sol
@@ -74,7 +74,7 @@ contract TopUpAllowedRecipients is TrustedCaller, IEVMScriptFactory {
     /// recipients - addresses of recipients to top up
     /// amounts - corresponding amounts of token to transfer
     /// @dev note that the arrays below has one extra element to store limit enforcement calls
-    function createEVMScript(address _creator, bytes memory _evmScriptCallData)
+    function createEVMScript(address _creator, bytes calldata _evmScriptCallData)
         external
         view
         override
@@ -109,7 +109,7 @@ contract TopUpAllowedRecipients is TrustedCaller, IEVMScriptFactory {
     /// @return token Address of payout token
     /// @return recipients Addresses of recipients to top up
     /// @return amounts Amounts of token to transfer
-    function decodeEVMScriptCallData(bytes memory _evmScriptCallData)
+    function decodeEVMScriptCallData(bytes calldata _evmScriptCallData)
         external
         pure
         returns (address token, address[] memory recipients, uint256[] memory amounts)
@@ -130,7 +130,7 @@ contract TopUpAllowedRecipients is TrustedCaller, IEVMScriptFactory {
         require(_recipients.length > 0, ERROR_EMPTY_DATA);
         require(allowedTokensRegistry.isTokenAllowed(token), ERROR_TOKEN_NOT_ALLOWED);
 
-        uint256 totalAmount = 0;
+        uint256 totalAmount;
 
         for (uint256 i = 0; i < _recipients.length; ++i) {
             require(_amounts[i] > 0, ERROR_ZERO_AMOUNT);
@@ -144,7 +144,7 @@ contract TopUpAllowedRecipients is TrustedCaller, IEVMScriptFactory {
         _validateSpendableBalance(normalizedAmount);
     }
 
-    function _decodeEVMScriptCallData(bytes memory _evmScriptCallData)
+    function _decodeEVMScriptCallData(bytes calldata _evmScriptCallData)
         private
         pure
         returns (address token, address[] memory recipients, uint256[] memory amounts)