Update SDVT target limit factory on Holesky #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katamarinaki
approved these changes
Jul 2, 2024
There was a problem hiding this comment.
LGTM, but keep in mind that since the factory will be updated only for the Holesky testnet, any release on prod will break the process of this motion creation. We can release on the testnet now, but we shouldn't release anything on prod until the backward capability fix is merged to the develop branch.
I will handle it and prepare an update in the coming days.
katamarinaki
changed the base branch from
develop
to
feat/sdvt-target-limit-factory-v2
katamarinaki
merged commit 7cfe625
into
lidofinance:feat/sdvt-target-limit-factory-v2
1 check failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.