fix: csm motion input validation and encode

lidofinance · Sep 13, 2024 · 42ef80d · 42ef80d
1 parent 65197c5
commit 42ef80d
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/modules/motions/ui/MotionDescription/DescCSMSettleElStealingPenalty.tsx b/modules/motions/ui/MotionDescription/DescCSMSettleElStealingPenalty.tsx
@@ -10,10 +10,10 @@ export function DescCSMSettleElStealingPenalty({
     <>
       Settle (confirm) EL Rewards Stealing penalty for the following CSM{' '}
       {pluralize(callData.length, 'operator')}:
-      {callData.map(item => {
+      {callData.map((item, index) => {
         const nodeOperatorId = item.toNumber()
 
-        return <div key={nodeOperatorId}>NO #{nodeOperatorId}</div>
+        return <div key={index}>NO #{nodeOperatorId}</div>
       })}
     </>
   )

diff --git a/modules/motions/ui/MotionFormStartNew/Parts/StartNewCSMSettleElStealingPenalty.tsx b/modules/motions/ui/MotionFormStartNew/Parts/StartNewCSMSettleElStealingPenalty.tsx
@@ -114,7 +114,7 @@ export const formParts = createMotionFormPart({
 
                 <Fieldset>
                   <InputNumberControl
-                    name={`${fieldNames.nodeOperators}.${fieldIndex}.nodeOperatorId`}
+                    name={`${fieldNames.nodeOperators}.${fieldIndex}.id`}
                     label="Node operator ID"
                     rules={{
                       required: 'Field is required',
@@ -129,6 +129,15 @@ export const formParts = createMotionFormPart({
                           return 'Invalid node operator ID'
                         }
 
+                        const isAlreadyInInput = selectedNodeOperators.some(
+                          ({ id }, index) =>
+                            id === value && index !== fieldIndex,
+                        )
+
+                        if (isAlreadyInInput) {
+                          return 'This ID is already in the list'
+                        }
+
                         return true
                       },
                     }}