Add tests for EscrowState library #92
Conversation
sandstone-ag
force-pushed
the
feature/escrow-state-tests
branch
from
7ba81ea
to
a1dc2c7
Compare
| // initialize() | ||
| // --- | ||
|
|
||
| function testFuzz_initialize_happyPath(uint32 minAssetsLockSeconds) external { |
There was a problem hiding this comment.
The Duration type may be used as a parameter to avoid later casting from uint32.
|
|
||
| EscrowState.initialize(_context, minAssetsLockDuration); | ||
|
|
||
| checkContext(State.SignallingEscrow, minAssetsLockDuration, D0, D0, T0); |
There was a problem hiding this comment.
It's better to use named parameters for the better readability:
checkContext({
state: State.SignallingEscrow,
minAssetsLockDuration: minAssetsLockDuration,
rageQuitExtensionDelay: D0,
rageQuitWithdrawalsTimelock: D0,
rageQuitExtensionDelayStartedAt: T0
});| _context.rageQuitExtensionDelay = rageQuitExtensionDelay; | ||
| _context.rageQuitWithdrawalsTimelock = rageQuitWithdrawalsTimelock; | ||
|
|
||
| vm.warp( |
There was a problem hiding this comment.
The UnitTest._wait() method may be used
There was a problem hiding this comment.
I'm not sure that it will make the test easier to understand, take a look pls at these lines
https://github.com/lidofinance/dual-governance/pull/92/files#diff-94006bb4d7eaa8960b0a0a1fd4de0d02c0d50140ca8857d0ba68052b5aeee11fR229-R234
However I replaced all vm.warp() calls with _wait() as you requested.
| { | ||
| _context.rageQuitExtensionDelayStartedAt = Timestamps.from(rageQuitExtensionDelayStartedAtSeconds); | ||
| bool res = EscrowState.isRageQuitExtensionDelayStarted(_context); | ||
| assert(res == _context.rageQuitExtensionDelayStartedAt.isNotZero()); |
There was a problem hiding this comment.
Do not use Solidity's native assert() method in tests. Instead, use Foundry's assertEq(), assertTrue(), etc.
sandstone-ag
force-pushed
the
feature/escrow-state-tests
branch
from
a1dc2c7
to
3260959
Compare
sandstone-ag
force-pushed
the
feature/escrow-state-tests
branch
2 times, most recently
from
106a529
to
8c2f6e3
Compare
sandstone-ag
force-pushed
the
feature/escrow-state-tests
branch
from
8c2f6e3
to
3b9eb9d
Compare
No description provided.