Add tests on cancelAllPendingProposals return value

lidofinance · Sep 25, 2024 · 0c8f50e · 0c8f50e
1 parent c41e546
commit 0c8f50e
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 6 deletions.
diff --git a/test/unit/DualGovernance.t.sol b/test/unit/DualGovernance.t.sol
@@ -251,8 +251,9 @@ contract DualGovernanceUnitTests is UnitTest {
         vm.expectEmit();
         emit DualGovernance.CancelAllPendingProposalsSkipped();
 
-        _dualGovernance.cancelAllPendingProposals();
+        bool isProposalsCancelled = _dualGovernance.cancelAllPendingProposals();
 
+        assertFalse(isProposalsCancelled);
         assertEq(_timelock.getProposalsCount(), 1);
         assertEq(_timelock.lastCancelledProposalId(), 0);
     }
@@ -286,8 +287,9 @@ contract DualGovernanceUnitTests is UnitTest {
         vm.expectEmit();
         emit DualGovernance.CancelAllPendingProposalsSkipped();
 
-        _dualGovernance.cancelAllPendingProposals();
+        bool isProposalsCancelled = _dualGovernance.cancelAllPendingProposals();
 
+        assertFalse(isProposalsCancelled);
         assertEq(_timelock.getProposalsCount(), 1);
         assertEq(_timelock.lastCancelledProposalId(), 0);
     }
@@ -312,8 +314,9 @@ contract DualGovernanceUnitTests is UnitTest {
         vm.expectEmit();
         emit DualGovernance.CancelAllPendingProposalsSkipped();
 
-        _dualGovernance.cancelAllPendingProposals();
+        bool isProposalsCancelled = _dualGovernance.cancelAllPendingProposals();
 
+        assertFalse(isProposalsCancelled);
         assertEq(_timelock.getProposalsCount(), 1);
         assertEq(_timelock.lastCancelledProposalId(), 0);
     }
@@ -333,8 +336,9 @@ contract DualGovernanceUnitTests is UnitTest {
         vm.expectEmit();
         emit DualGovernance.CancelAllPendingProposalsExecuted();
 
-        _dualGovernance.cancelAllPendingProposals();
+        bool isProposalsCancelled = _dualGovernance.cancelAllPendingProposals();
 
+        assertTrue(isProposalsCancelled);
         assertEq(_timelock.getProposalsCount(), 1);
         assertEq(_timelock.lastCancelledProposalId(), 1);
     }
@@ -361,8 +365,9 @@ contract DualGovernanceUnitTests is UnitTest {
         vm.expectEmit();
         emit DualGovernance.CancelAllPendingProposalsExecuted();
 
-        _dualGovernance.cancelAllPendingProposals();
+        bool isProposalsCancelled = _dualGovernance.cancelAllPendingProposals();
 
+        assertTrue(isProposalsCancelled);
         assertEq(_timelock.getProposalsCount(), 1);
         assertEq(_timelock.lastCancelledProposalId(), 1);
     }

diff --git a/test/unit/TimelockedGovernance.t.sol b/test/unit/TimelockedGovernance.t.sol
@@ -85,8 +85,9 @@ contract TimelockedGovernanceUnitTests is UnitTest {
         _timelock.setSchedule(1);
         _timelockedGovernance.scheduleProposal(1);
 
-        _timelockedGovernance.cancelAllPendingProposals();
+        bool isProposalsCancelled = _timelockedGovernance.cancelAllPendingProposals();
 
+        assertTrue(isProposalsCancelled);
         assertEq(_timelock.getLastCancelledProposalId(), 2);
     }