Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SR-1.5 updates #402

Merged
merged 23 commits into from
Oct 25, 2024
Merged

SR-1.5 updates #402

merged 23 commits into from
Oct 25, 2024

Conversation

krogla
Copy link
Member

@krogla krogla commented Aug 8, 2024

No description provided.

@krogla krogla added the documentation Improvements or additions to documentation label Aug 8, 2024
@krogla krogla changed the title SR-1.5 updates [WIP] SR-1.5 updates Aug 8, 2024
@mkurayan
Copy link
Contributor

mkurayan commented Sep 6, 2024 •
edited
Loading

⚠️ Documentation Update Needed for deposit-security-module.md:

The maxDepositsPerBlock and minDepositBlockDistance parameters have been relocated from the Deposit Security Module (DSM) to the Staking Router level. The documentation should be updated to reflect these changes.

  • Remove or update the descriptions of maxDepositsPerBlock and minDepositBlockDistance from the DSM documentation.
  • Eliminate references to any getters and setters, such as getMinDepositBlockDistance, which were removed as part of the Staking Router 1.5 (SR-1.5) scope updates.

@mkurayan
Copy link
Contributor

mkurayan commented Sep 6, 2024

@vpetrenko The Sanity Checker documentation currently includes the description for oneOffCLBalanceDecreaseBPLimit and its related methods.

  • Please update or remove the description for these items to align with the latest changes related to the negative rebase feature.

@mkurayan
Copy link
Contributor

mkurayan commented Sep 6, 2024

Add to node-operators-registry.md description of

  • new decreaseVettedSigningKeysCount method
  • updateTargetValidatorsLimits

@eddort eddort marked this pull request as ready for review October 21, 2024 11:33
@eddort eddort requested review from a team as code owners October 21, 2024 11:33
@eddort eddort changed the title [WIP] SR-1.5 updates SR-1.5 updates Oct 21, 2024
TheDZhon
TheDZhon requested changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

The only concern here is the forced / boosted ambiguity.

docs/guides/oracle-spec/validator-exit-bus.md Outdated Show resolved Hide resolved
docs/guides/oracle-spec/validator-exit-bus.md Outdated Show resolved Hide resolved
docs/guides/oracle-spec/validator-exit-bus.md Outdated Show resolved Hide resolved
TheDZhon
TheDZhon approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GG

rkolpakov
rkolpakov approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@rkolpakov rkolpakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eddort eddort merged commit 45dea89 into main Oct 25, 2024
1 check passed
@eddort eddort deleted the feat/sr-1.5 branch October 25, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@F4ever F4ever F4ever left review comments

@rkolpakov rkolpakov rkolpakov approved these changes

@TheDZhon TheDZhon TheDZhon approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@krogla @mkurayan @TheDZhon @rkolpakov @F4ever @eddort @vpetrenko @vp4242