-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OracleReportSanityChecker docs #225
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like reference format is really differs from other docs. Can we do it in one style, please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better, thank you. But have a couple more of a formatting requests, sorry.
We really need to do it automatically in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks to your efforts and work done, and with this PR, we have enshrined in docs a significant part of the word-of-mouth knowledge 👍
Please consider integrating the following changes if suitable: #226 🙏
…ecker-proposals-dzhon Fix: some edit proposals
Let's ship it 🚢 Thank you, @Psirex and @folkyatina 🍻 |
The latest changes in |
I'm not sure that it's so critical and I tend to use lists instead of tables too, because tables is so hard to format and have a type, which already included in the declaration part |
Can't say that I have a strong preference here. Both arguments are sound 🤔 My general idea is that we would need a polishing iteration anyway, in the end, to unify the style again (cause we miss something else) |
I agree with @folkyatina. Adding only two points from myself:
|
Added "final clean-up" subtask in the master issue #217 |
No description provided.