Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lido v2 withdrawals-related contracts documentation #221

Merged
merged 6 commits into from
Jul 27, 2023

Conversation

folkyatina
Copy link
Member

@folkyatina folkyatina commented Jun 27, 2023

Related to #217

  • WithdrawalVault
  • WithdrawalQueue

@folkyatina folkyatina requested a review from a team as a code owner June 27, 2023 10:09
@folkyatina folkyatina marked this pull request as draft June 27, 2023 10:09
@folkyatina folkyatina changed the base branch from main to lido-v2/lido-docs June 27, 2023 10:09
Base automatically changed from lido-v2/lido-docs to main June 27, 2023 15:57
@TheDZhon TheDZhon mentioned this pull request Jun 27, 2023
33 tasks
@folkyatina folkyatina marked this pull request as ready for review July 20, 2023 09:40
Copy link
Contributor

@arwer13 arwer13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A huuuuge new doc 🤩🙏

docs/contracts/withdrawal-vault.md Outdated Show resolved Hide resolved
docs/contracts/withdrawal-vault.md Outdated Show resolved Hide resolved
docs/contracts/withdrawal-vault.md Outdated Show resolved Hide resolved
docs/contracts/withdrawal-vault.md Outdated Show resolved Hide resolved
docs/contracts/withdrawal-queue-erc721.md Outdated Show resolved Hide resolved
docs/contracts/withdrawal-queue-erc721.md Outdated Show resolved Hide resolved
docs/contracts/withdrawal-queue-erc721.md Outdated Show resolved Hide resolved
docs/contracts/withdrawal-queue-erc721.md Outdated Show resolved Hide resolved
docs/contracts/withdrawal-queue-erc721.md Outdated Show resolved Hide resolved
docs/contracts/withdrawal-queue-erc721.md Outdated Show resolved Hide resolved
Copy link
Contributor

@Psirex Psirex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greatly detailed docs! Nice work 👍🏻 Left only some minor comments

docs/contracts/withdrawal-queue-erc721.md Outdated Show resolved Hide resolved
docs/contracts/withdrawal-queue-erc721.md Outdated Show resolved Hide resolved
docs/contracts/withdrawal-queue-erc721.md Outdated Show resolved Hide resolved
docs/contracts/withdrawal-queue-erc721.md Outdated Show resolved Hide resolved
docs/contracts/withdrawal-queue-erc721.md Outdated Show resolved Hide resolved
docs/contracts/withdrawal-queue-erc721.md Outdated Show resolved Hide resolved
docs/contracts/withdrawal-queue-erc721.md Show resolved Hide resolved
docs/contracts/withdrawal-queue-erc721.md Show resolved Hide resolved
docs/contracts/withdrawal-queue-erc721.md Show resolved Hide resolved
docs/contracts/withdrawal-queue-erc721.md Show resolved Hide resolved
@folkyatina folkyatina requested a review from arwer13 July 27, 2023 09:07
@folkyatina folkyatina merged commit b0ffadc into main Jul 27, 2023
1 check passed
@folkyatina folkyatina deleted the lido-v2/withdrawals-docs branch July 27, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants