Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V2 integration guide #204

Merged
merged 9 commits into from
May 16, 2023
Merged

V2 integration guide #204

merged 9 commits into from
May 16, 2023

Conversation

folkyatina
Copy link
Member

@folkyatina folkyatina commented May 12, 2023 •
edited
Loading

Fixes for the integration guide with V2-related changes.

@folkyatina folkyatina marked this pull request as draft May 12, 2023 10:20
@folkyatina
fix: stETH description for V2
3984cf7
@folkyatina
remove beacon chain adoption risk.
630f8d4 
We have Shapell and The Merge and there is no chance
that Ethereum will drop the Beacon chain
TheDZhon
TheDZhon reviewed May 15, 2023
View reviewed changes
Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for a solid start 🚀

Left notes, suggestions, and concerns for the currently presented content.

docs/guides/steth-integration-guide.md Show resolved Hide resolved
docs/guides/steth-integration-guide.md Show resolved Hide resolved
docs/guides/steth-integration-guide.md Show resolved Hide resolved
docs/guides/steth-integration-guide.md Show resolved Hide resolved
docs/guides/steth-integration-guide.md Show resolved Hide resolved
docs/guides/steth-integration-guide.md Show resolved Hide resolved
docs/guides/steth-integration-guide.md Outdated Show resolved Hide resolved
docs/guides/steth-integration-guide.md Outdated Show resolved Hide resolved
docs/guides/steth-integration-guide.md Show resolved Hide resolved
docs/guides/steth-integration-guide.md Outdated Show resolved Hide resolved
@folkyatina
remove BLS key management risk
7cd8c2f 
All validators are migrated to 0x01 withdrawal credentials
@folkyatina
incorporated some feedback
a632a03
@folkyatina
More polish
55b9cef
@TheDZhon TheDZhon marked this pull request as ready for review May 16, 2023 13:25
@TheDZhon TheDZhon self-requested a review May 16, 2023 13:31
TheDZhon
TheDZhon approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go, as the first version for the Lido V2 upgrade.

Will need a bit more updates and polishings in the future.

@TheDZhon TheDZhon merged commit 1c13cd8 into main May 16, 2023
@TheDZhon TheDZhon deleted the v2_integration_guide branch May 16, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grstepanov grstepanov grstepanov left review comments

@TheDZhon TheDZhon TheDZhon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@folkyatina @TheDZhon @grstepanov