Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mellow deposit strategy #230

Merged
merged 7 commits into from
Jul 4, 2024
Merged

Mellow deposit strategy #230

merged 7 commits into from
Jul 4, 2024

Conversation

hweawer
Copy link
Contributor

@hweawer hweawer commented Jul 2, 2024

No description provided.

@hweawer hweawer requested a review from F4ever July 2, 2024 16:23
@hweawer hweawer requested a review from a team as a code owner July 2, 2024 16:23
@hweawer hweawer self-assigned this Jul 2, 2024
@hweawer hweawer changed the base branch from main to develop July 2, 2024 16:23
src/variables.py Outdated Show resolved Hide resolved
@hweawer hweawer requested a review from F4ever July 2, 2024 18:14
src/blockchain/contracts/lido.py Outdated Show resolved Hide resolved
src/blockchain/contracts/lido_locator.py Show resolved Hide resolved
src/blockchain/deposit_strategy/curated_module.py Outdated Show resolved Hide resolved
src/blockchain/deposit_strategy/curated_module.py Outdated Show resolved Hide resolved
src/blockchain/web3_extentions/direct_deposit.py Outdated Show resolved Hide resolved
src/bots/depositor.py Outdated Show resolved Hide resolved
@hweawer hweawer requested a review from F4ever July 3, 2024 10:03
@hweawer hweawer merged commit 28904ec into develop Jul 4, 2024
6 checks passed
hweawer added a commit that referenced this pull request Aug 5, 2024
* chore: set default strategy

* Upgrade python to 3.12

* Upgrade poetry

* upgrade curl

* Mellow mvp (#224)

* Mellow direct deposit, skip ABI

* Prepare direct deposit transaction

* Property checking

* Fix linter

* amount parameter in the contract

* Fix comments

* Check variable not set

* Contract abi integration test

* Add fixtures

* Remove amount parameter from abi

* Formatter changes

* Formatter changes

* Holesky mark in tests

* Test balanceOf of weth

* Renamings

* Rename mark

* block_identifier

* Update src/variables.py

Co-authored-by: Raman Siamionau <[email protected]>

* Fix comments

* Renamed env var in pipeline

* Change module to deposit

* Send mellow transaction

* Change comment

* DD description

* Update README.md

Co-authored-by: Raman Siamionau <[email protected]>

* Refactor sending mellow transaction

* Refactor sending mellow transaction

* is_mellow_depositable unit test

* Unit test for sending mellow tx

* Formatting

---------

Co-authored-by: Raman Siamionau <[email protected]>

* Metric for modules (#229)

* Expose modules metric

* Reorder

* Reorder

* Update src/metrics/metrics.py

Co-authored-by: Raman Siamionau <[email protected]>

---------

Co-authored-by: Raman Siamionau <[email protected]>

* Log env vars (#227)

* Log public env vars

* Add chain_id

* Public env vars in prometheus metric

* Add message to a log

* Change info description

* Update src/variables.py

Co-authored-by: Raman Siamionau <[email protected]>

* Update src/metrics/metrics.py

Co-authored-by: Raman Siamionau <[email protected]>

* Remove prefix, not assert

* Fix imports

---------

Co-authored-by: Raman Siamionau <[email protected]>

* Fix Info metircs endpoint(#231)

* Fix log string

* Change forematting

* Convert values to strings

* remove convertion

* Mellow deposit strategy (#230)

* Change validation for mellow deposits

* Load WQ contract from the locator

* Refactor

* Change log message

* Beffered ether

* Change ABI

* Move check inside is_mellow_depositable

* Add ping type to the rabbit messages in the unvetter

* Mellow new ABIs

* Remove old build metrics (#239)

* Add mellow variable to examples (#237)

* Add mellow variable to examples

* Remove import

* Update holesky address

* Add account to variables (#241)

* Add account to metrics

* Fix field ref

* Change to propery

* Direct access property

* Separate mellow flow (#235)

* Separate mellow flow

* Formatting

* Rerun integration tests

* Strategy return

* Rewrite to abstract classes

* Fix formatting

* Fix bug with return

* Restructure

* remove init

* _is_mellow

* Fix tests

* Fix signs test

* Fix integration

* Fix unit test

* Mellow test

* Update src/blockchain/deposit_strategy/base_deposit_strategy.py

Co-authored-by: Raman Siamionau <[email protected]>

* Refactor

* Renamings

* Imports

* inject dependecies

---------

Co-authored-by: Raman Siamionau <[email protected]>

* Metric per module (#244)

* Per module metric

* FOrmatting

* Fix error repr

---------

Co-authored-by: F4ever <[email protected]>
hweawer added a commit that referenced this pull request Aug 12, 2024
* chore: set default strategy

* Upgrade python to 3.12

* Upgrade poetry

* upgrade curl

* Mellow mvp (#224)

* Mellow direct deposit, skip ABI

* Prepare direct deposit transaction

* Property checking

* Fix linter

* amount parameter in the contract

* Fix comments

* Check variable not set

* Contract abi integration test

* Add fixtures

* Remove amount parameter from abi

* Formatter changes

* Formatter changes

* Holesky mark in tests

* Test balanceOf of weth

* Renamings

* Rename mark

* block_identifier

* Update src/variables.py

Co-authored-by: Raman Siamionau <[email protected]>

* Fix comments

* Renamed env var in pipeline

* Change module to deposit

* Send mellow transaction

* Change comment

* DD description

* Update README.md

Co-authored-by: Raman Siamionau <[email protected]>

* Refactor sending mellow transaction

* Refactor sending mellow transaction

* is_mellow_depositable unit test

* Unit test for sending mellow tx

* Formatting

---------

Co-authored-by: Raman Siamionau <[email protected]>

* Metric for modules (#229)

* Expose modules metric

* Reorder

* Reorder

* Update src/metrics/metrics.py

Co-authored-by: Raman Siamionau <[email protected]>

---------

Co-authored-by: Raman Siamionau <[email protected]>

* Log env vars (#227)

* Log public env vars

* Add chain_id

* Public env vars in prometheus metric

* Add message to a log

* Change info description

* Update src/variables.py

Co-authored-by: Raman Siamionau <[email protected]>

* Update src/metrics/metrics.py

Co-authored-by: Raman Siamionau <[email protected]>

* Remove prefix, not assert

* Fix imports

---------

Co-authored-by: Raman Siamionau <[email protected]>

* Fix Info metircs endpoint(#231)

* Fix log string

* Change forematting

* Convert values to strings

* remove convertion

* Mellow deposit strategy (#230)

* Change validation for mellow deposits

* Load WQ contract from the locator

* Refactor

* Change log message

* Beffered ether

* Change ABI

* Move check inside is_mellow_depositable

* Add ping type to the rabbit messages in the unvetter

* Mellow new ABIs

* Remove old build metrics (#239)

* Add mellow variable to examples (#237)

* Add mellow variable to examples

* Remove import

* Update holesky address

* Add account to variables (#241)

* Add account to metrics

* Fix field ref

* Change to propery

* Direct access property

* Separate mellow flow (#235)

* Separate mellow flow

* Formatting

* Rerun integration tests

* Strategy return

* Rewrite to abstract classes

* Fix formatting

* Fix bug with return

* Restructure

* remove init

* _is_mellow

* Fix tests

* Fix signs test

* Fix integration

* Fix unit test

* Mellow test

* Update src/blockchain/deposit_strategy/base_deposit_strategy.py

Co-authored-by: Raman Siamionau <[email protected]>

* Refactor

* Renamings

* Imports

* inject dependecies

---------

Co-authored-by: Raman Siamionau <[email protected]>

* Metric per module (#244)

* Per module metric

* FOrmatting

* Fix error repr

* Metrics for checks (#246)

* Metrics for different check statuses

* Formatting

* Fix early returns (#248)

* Mellow fallback (#250)

* Mellow fallback

* Fix unit tests

* Fix DepositorBot constructor in test

* Fix positional argument

* Double max deposit count

* Fix test

* Improve test

* Sender chain in integrations

* Without sender chain

* Reorder

* Remove redundant function

* New metric for mellow

* Cast

* Merge main

---------

Co-authored-by: F4ever <[email protected]>
hweawer added a commit that referenced this pull request Aug 12, 2024
)

* Upgrade curl

* Mellow integration (#247)

* chore: set default strategy

* Upgrade python to 3.12

* Upgrade poetry

* upgrade curl

* Mellow mvp (#224)

* Mellow direct deposit, skip ABI

* Prepare direct deposit transaction

* Property checking

* Fix linter

* amount parameter in the contract

* Fix comments

* Check variable not set

* Contract abi integration test

* Add fixtures

* Remove amount parameter from abi

* Formatter changes

* Formatter changes

* Holesky mark in tests

* Test balanceOf of weth

* Renamings

* Rename mark

* block_identifier

* Update src/variables.py

Co-authored-by: Raman Siamionau <[email protected]>

* Fix comments

* Renamed env var in pipeline

* Change module to deposit

* Send mellow transaction

* Change comment

* DD description

* Update README.md

Co-authored-by: Raman Siamionau <[email protected]>

* Refactor sending mellow transaction

* Refactor sending mellow transaction

* is_mellow_depositable unit test

* Unit test for sending mellow tx

* Formatting

---------

Co-authored-by: Raman Siamionau <[email protected]>

* Metric for modules (#229)

* Expose modules metric

* Reorder

* Reorder

* Update src/metrics/metrics.py

Co-authored-by: Raman Siamionau <[email protected]>

---------

Co-authored-by: Raman Siamionau <[email protected]>

* Log env vars (#227)

* Log public env vars

* Add chain_id

* Public env vars in prometheus metric

* Add message to a log

* Change info description

* Update src/variables.py

Co-authored-by: Raman Siamionau <[email protected]>

* Update src/metrics/metrics.py

Co-authored-by: Raman Siamionau <[email protected]>

* Remove prefix, not assert

* Fix imports

---------

Co-authored-by: Raman Siamionau <[email protected]>

* Fix Info metircs endpoint(#231)

* Fix log string

* Change forematting

* Convert values to strings

* remove convertion

* Mellow deposit strategy (#230)

* Change validation for mellow deposits

* Load WQ contract from the locator

* Refactor

* Change log message

* Beffered ether

* Change ABI

* Move check inside is_mellow_depositable

* Add ping type to the rabbit messages in the unvetter

* Mellow new ABIs

* Remove old build metrics (#239)

* Add mellow variable to examples (#237)

* Add mellow variable to examples

* Remove import

* Update holesky address

* Add account to variables (#241)

* Add account to metrics

* Fix field ref

* Change to propery

* Direct access property

* Separate mellow flow (#235)

* Separate mellow flow

* Formatting

* Rerun integration tests

* Strategy return

* Rewrite to abstract classes

* Fix formatting

* Fix bug with return

* Restructure

* remove init

* _is_mellow

* Fix tests

* Fix signs test

* Fix integration

* Fix unit test

* Mellow test

* Update src/blockchain/deposit_strategy/base_deposit_strategy.py

Co-authored-by: Raman Siamionau <[email protected]>

* Refactor

* Renamings

* Imports

* inject dependecies

---------

Co-authored-by: Raman Siamionau <[email protected]>

* Metric per module (#244)

* Per module metric

* FOrmatting

* Fix error repr

---------

Co-authored-by: F4ever <[email protected]>

* Release mellow main (#254)

* chore: set default strategy

* Upgrade python to 3.12

* Upgrade poetry

* upgrade curl

* Mellow mvp (#224)

* Mellow direct deposit, skip ABI

* Prepare direct deposit transaction

* Property checking

* Fix linter

* amount parameter in the contract

* Fix comments

* Check variable not set

* Contract abi integration test

* Add fixtures

* Remove amount parameter from abi

* Formatter changes

* Formatter changes

* Holesky mark in tests

* Test balanceOf of weth

* Renamings

* Rename mark

* block_identifier

* Update src/variables.py

Co-authored-by: Raman Siamionau <[email protected]>

* Fix comments

* Renamed env var in pipeline

* Change module to deposit

* Send mellow transaction

* Change comment

* DD description

* Update README.md

Co-authored-by: Raman Siamionau <[email protected]>

* Refactor sending mellow transaction

* Refactor sending mellow transaction

* is_mellow_depositable unit test

* Unit test for sending mellow tx

* Formatting

---------

Co-authored-by: Raman Siamionau <[email protected]>

* Metric for modules (#229)

* Expose modules metric

* Reorder

* Reorder

* Update src/metrics/metrics.py

Co-authored-by: Raman Siamionau <[email protected]>

---------

Co-authored-by: Raman Siamionau <[email protected]>

* Log env vars (#227)

* Log public env vars

* Add chain_id

* Public env vars in prometheus metric

* Add message to a log

* Change info description

* Update src/variables.py

Co-authored-by: Raman Siamionau <[email protected]>

* Update src/metrics/metrics.py

Co-authored-by: Raman Siamionau <[email protected]>

* Remove prefix, not assert

* Fix imports

---------

Co-authored-by: Raman Siamionau <[email protected]>

* Fix Info metircs endpoint(#231)

* Fix log string

* Change forematting

* Convert values to strings

* remove convertion

* Mellow deposit strategy (#230)

* Change validation for mellow deposits

* Load WQ contract from the locator

* Refactor

* Change log message

* Beffered ether

* Change ABI

* Move check inside is_mellow_depositable

* Add ping type to the rabbit messages in the unvetter

* Mellow new ABIs

* Remove old build metrics (#239)

* Add mellow variable to examples (#237)

* Add mellow variable to examples

* Remove import

* Update holesky address

* Add account to variables (#241)

* Add account to metrics

* Fix field ref

* Change to propery

* Direct access property

* Separate mellow flow (#235)

* Separate mellow flow

* Formatting

* Rerun integration tests

* Strategy return

* Rewrite to abstract classes

* Fix formatting

* Fix bug with return

* Restructure

* remove init

* _is_mellow

* Fix tests

* Fix signs test

* Fix integration

* Fix unit test

* Mellow test

* Update src/blockchain/deposit_strategy/base_deposit_strategy.py

Co-authored-by: Raman Siamionau <[email protected]>

* Refactor

* Renamings

* Imports

* inject dependecies

---------

Co-authored-by: Raman Siamionau <[email protected]>

* Metric per module (#244)

* Per module metric

* FOrmatting

* Fix error repr

* Metrics for checks (#246)

* Metrics for different check statuses

* Formatting

* Fix early returns (#248)

* Mellow fallback (#250)

* Mellow fallback

* Fix unit tests

* Fix DepositorBot constructor in test

* Fix positional argument

* Double max deposit count

* Fix test

* Improve test

* Sender chain in integrations

* Without sender chain

* Reorder

* Remove redundant function

* New metric for mellow

* Cast

* Merge main

---------

Co-authored-by: F4ever <[email protected]>

* If the mellow strategy is failing fallback to the default strategy

---------

Co-authored-by: Raman Siamionau <[email protected]>
hweawer added a commit that referenced this pull request Aug 12, 2024
* Change validation for mellow deposits

* Load WQ contract from the locator

* Refactor

* Change log message

* Beffered ether

* Change ABI

* Move check inside is_mellow_depositable
hweawer added a commit that referenced this pull request Aug 12, 2024
)

* Upgrade curl

* Mellow integration (#247)

* chore: set default strategy

* Upgrade python to 3.12

* Upgrade poetry

* upgrade curl

* Mellow mvp (#224)

* Mellow direct deposit, skip ABI

* Prepare direct deposit transaction

* Property checking

* Fix linter

* amount parameter in the contract

* Fix comments

* Check variable not set

* Contract abi integration test

* Add fixtures

* Remove amount parameter from abi

* Formatter changes

* Formatter changes

* Holesky mark in tests

* Test balanceOf of weth

* Renamings

* Rename mark

* block_identifier

* Update src/variables.py

Co-authored-by: Raman Siamionau <[email protected]>

* Fix comments

* Renamed env var in pipeline

* Change module to deposit

* Send mellow transaction

* Change comment

* DD description

* Update README.md

Co-authored-by: Raman Siamionau <[email protected]>

* Refactor sending mellow transaction

* Refactor sending mellow transaction

* is_mellow_depositable unit test

* Unit test for sending mellow tx

* Formatting

---------

Co-authored-by: Raman Siamionau <[email protected]>

* Metric for modules (#229)

* Expose modules metric

* Reorder

* Reorder

* Update src/metrics/metrics.py

Co-authored-by: Raman Siamionau <[email protected]>

---------

Co-authored-by: Raman Siamionau <[email protected]>

* Log env vars (#227)

* Log public env vars

* Add chain_id

* Public env vars in prometheus metric

* Add message to a log

* Change info description

* Update src/variables.py

Co-authored-by: Raman Siamionau <[email protected]>

* Update src/metrics/metrics.py

Co-authored-by: Raman Siamionau <[email protected]>

* Remove prefix, not assert

* Fix imports

---------

Co-authored-by: Raman Siamionau <[email protected]>

* Fix Info metircs endpoint(#231)

* Fix log string

* Change forematting

* Convert values to strings

* remove convertion

* Mellow deposit strategy (#230)

* Change validation for mellow deposits

* Load WQ contract from the locator

* Refactor

* Change log message

* Beffered ether

* Change ABI

* Move check inside is_mellow_depositable

* Add ping type to the rabbit messages in the unvetter

* Mellow new ABIs

* Remove old build metrics (#239)

* Add mellow variable to examples (#237)

* Add mellow variable to examples

* Remove import

* Update holesky address

* Add account to variables (#241)

* Add account to metrics

* Fix field ref

* Change to propery

* Direct access property

* Separate mellow flow (#235)

* Separate mellow flow

* Formatting

* Rerun integration tests

* Strategy return

* Rewrite to abstract classes

* Fix formatting

* Fix bug with return

* Restructure

* remove init

* _is_mellow

* Fix tests

* Fix signs test

* Fix integration

* Fix unit test

* Mellow test

* Update src/blockchain/deposit_strategy/base_deposit_strategy.py

Co-authored-by: Raman Siamionau <[email protected]>

* Refactor

* Renamings

* Imports

* inject dependecies

---------

Co-authored-by: Raman Siamionau <[email protected]>

* Metric per module (#244)

* Per module metric

* FOrmatting

* Fix error repr

---------

Co-authored-by: F4ever <[email protected]>

* Release mellow main (#254)

* chore: set default strategy

* Upgrade python to 3.12

* Upgrade poetry

* upgrade curl

* Mellow mvp (#224)

* Mellow direct deposit, skip ABI

* Prepare direct deposit transaction

* Property checking

* Fix linter

* amount parameter in the contract

* Fix comments

* Check variable not set

* Contract abi integration test

* Add fixtures

* Remove amount parameter from abi

* Formatter changes

* Formatter changes

* Holesky mark in tests

* Test balanceOf of weth

* Renamings

* Rename mark

* block_identifier

* Update src/variables.py

Co-authored-by: Raman Siamionau <[email protected]>

* Fix comments

* Renamed env var in pipeline

* Change module to deposit

* Send mellow transaction

* Change comment

* DD description

* Update README.md

Co-authored-by: Raman Siamionau <[email protected]>

* Refactor sending mellow transaction

* Refactor sending mellow transaction

* is_mellow_depositable unit test

* Unit test for sending mellow tx

* Formatting

---------

Co-authored-by: Raman Siamionau <[email protected]>

* Metric for modules (#229)

* Expose modules metric

* Reorder

* Reorder

* Update src/metrics/metrics.py

Co-authored-by: Raman Siamionau <[email protected]>

---------

Co-authored-by: Raman Siamionau <[email protected]>

* Log env vars (#227)

* Log public env vars

* Add chain_id

* Public env vars in prometheus metric

* Add message to a log

* Change info description

* Update src/variables.py

Co-authored-by: Raman Siamionau <[email protected]>

* Update src/metrics/metrics.py

Co-authored-by: Raman Siamionau <[email protected]>

* Remove prefix, not assert

* Fix imports

---------

Co-authored-by: Raman Siamionau <[email protected]>

* Fix Info metircs endpoint(#231)

* Fix log string

* Change forematting

* Convert values to strings

* remove convertion

* Mellow deposit strategy (#230)

* Change validation for mellow deposits

* Load WQ contract from the locator

* Refactor

* Change log message

* Beffered ether

* Change ABI

* Move check inside is_mellow_depositable

* Add ping type to the rabbit messages in the unvetter

* Mellow new ABIs

* Remove old build metrics (#239)

* Add mellow variable to examples (#237)

* Add mellow variable to examples

* Remove import

* Update holesky address

* Add account to variables (#241)

* Add account to metrics

* Fix field ref

* Change to propery

* Direct access property

* Separate mellow flow (#235)

* Separate mellow flow

* Formatting

* Rerun integration tests

* Strategy return

* Rewrite to abstract classes

* Fix formatting

* Fix bug with return

* Restructure

* remove init

* _is_mellow

* Fix tests

* Fix signs test

* Fix integration

* Fix unit test

* Mellow test

* Update src/blockchain/deposit_strategy/base_deposit_strategy.py

Co-authored-by: Raman Siamionau <[email protected]>

* Refactor

* Renamings

* Imports

* inject dependecies

---------

Co-authored-by: Raman Siamionau <[email protected]>

* Metric per module (#244)

* Per module metric

* FOrmatting

* Fix error repr

* Metrics for checks (#246)

* Metrics for different check statuses

* Formatting

* Fix early returns (#248)

* Mellow fallback (#250)

* Mellow fallback

* Fix unit tests

* Fix DepositorBot constructor in test

* Fix positional argument

* Double max deposit count

* Fix test

* Improve test

* Sender chain in integrations

* Without sender chain

* Reorder

* Remove redundant function

* New metric for mellow

* Cast

* Merge main

---------

Co-authored-by: F4ever <[email protected]>

* If the mellow strategy is failing fallback to the default strategy

---------

Co-authored-by: Raman Siamionau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants