Add explanation why different solc used #86 #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lxzrv
suggested changes
Oct 23, 2020
contracts/COMPILERS.md
Outdated
| Separately: | ||
|
|
||
| ```bash | ||
| npm run compile:4 |
skozin
reviewed
Oct 23, 2020
contracts/COMPILERS.md
Outdated
| @@ -0,0 +1,20 @@ | |||
| # Why we use different compilers | |||
|
|
|||
| For DePool project coordination, governance and funds management we use [Aragon](https://aragon.org/dao), well-developed and proven DAO Framework. The current stable release of its Kernel, [4.4.0](https://github.com/aragon/aragonOS/tree/v4.4.0) is fixed on the specific compiler version - [solc 0.4.24](https://solidity.readthedocs.io/en/v0.4.24/), that is currently outdated. Keeping security and consistency in mind, we decided to stay on older yet proven combination - for all the contracts under Aragon management (`DePool`, `stETH`, `DePoolOracle`) we use solc 0.4.24 release. | |||
There was a problem hiding this comment.
- well-developed and proven DAO Framework –> a well-developed and proven DAO Framework
- to stay on older yet proven combination –> to stay on an older yet proven combination
contracts/COMPILERS.md
Outdated
|
|
||
| For DePool project coordination, governance and funds management we use [Aragon](https://aragon.org/dao), well-developed and proven DAO Framework. The current stable release of its Kernel, [4.4.0](https://github.com/aragon/aragonOS/tree/v4.4.0) is fixed on the specific compiler version - [solc 0.4.24](https://solidity.readthedocs.io/en/v0.4.24/), that is currently outdated. Keeping security and consistency in mind, we decided to stay on older yet proven combination - for all the contracts under Aragon management (`DePool`, `stETH`, `DePoolOracle`) we use solc 0.4.24 release. | ||
|
|
||
| cstETH token, that acts as autonomous wrapper and not governed by Aragon, was inherited from OpenZeppelin's library, using one of its stable releases [3.1.0](https://github.com/OpenZeppelin/openzeppelin-contracts/releases/tag/v3.1.0), not the latest one, but with the moderately conservative. |
There was a problem hiding this comment.
"not the latest one, but with the moderately conservative" — the part after the comma is grammatically incorrect, it's missing an adjective. Did you mean that we were moderately conservative in choosing the release?
Anyway, I think that we can just safely remove this whole quoted ending without any loss of meaning.
ongrid
force-pushed
the
solc_explanation
branch
from
e5701d4
to
26ca0f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.