Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove PostTotalShares event checks #866

Merged
merged 1 commit into from
Oct 14, 2024
Merged

fix: remove PostTotalShares event checks #866

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions test/integration/accounting.integration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,11 +205,6 @@ describe("Accounting", () => {
const { sharesRateBefore, sharesRateAfter } = shareRateFromEvent(tokenRebasedEvent[0]);
expect(sharesRateBefore).to.be.lessThanOrEqual(sharesRateAfter);

const postTotalSharesEvent = ctx.getEvents(reportTxReceipt, "PostTotalShares");
expect(postTotalSharesEvent[0].args.preTotalPooledEther).to.equal(
postTotalSharesEvent[0].args.postTotalPooledEther + amountOfETHLocked,
);

const ethBalanceAfter = await ethers.provider.getBalance(lido.address);
expect(ethBalanceBefore).to.equal(ethBalanceAfter + amountOfETHLocked);
});
Expand Down Expand Up @@ -258,12 +253,6 @@ describe("Accounting", () => {
ethDistributedEvent[0].args.postCLBalance,
"ETHDistributed: CL balance differs from expected",
);

const postTotalSharesEvent = ctx.getEvents(reportTxReceipt, "PostTotalShares");
expect(postTotalSharesEvent[0].args.preTotalPooledEther + REBASE_AMOUNT).to.equal(
postTotalSharesEvent[0].args.postTotalPooledEther + amountOfETHLocked,
"PostTotalShares: TotalPooledEther differs from expected",
);
});

it("Should account correctly with positive CL rebase close to the limits", async () => {
Expand Down Expand Up @@ -380,12 +369,6 @@ describe("Accounting", () => {
ethDistributedEvent[0].args.postCLBalance,
"ETHDistributed: CL balance has not increased",
);

const postTotalSharesEvent = ctx.getEvents(reportTxReceipt, "PostTotalShares");
expect(postTotalSharesEvent[0].args.preTotalPooledEther + rebaseAmount).to.equal(
postTotalSharesEvent[0].args.postTotalPooledEther + amountOfETHLocked,
"PostTotalShares: TotalPooledEther has not increased",
);
});

it("Should account correctly if no EL rewards", async () => {
Expand Down
Loading