СStETH: discard OpenZeppelin ERC-20 burnable #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The burn(uint256 amount) and burnFrom(address account, uint256 amount) public functions both inherited from openzeppelin ERC20Burnable library should be removed since they have no use-case for users to discard their own tokens. After introducing the special functions `wrap` and `unwrap`, `burn(uint256 amount)` and `burnFrom(address account, uint256 amount)` became rudimentary. closes #192
Additional asserts CStETH has no burn and burnFrom methods anymore.
ongrid
changed the title
ongrid
changed the title
lxzrv
approved these changes
Nov 26, 2020
krogla
approved these changes
Nov 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
burn(uint256 amount)andburnFrom(address account, uint256 amount)public functions both inherited from openzeppelin ERC20Burnable library should be removed since they have no use-case for users to discard their own tokens. These actions lead to monetary loss of stETH tokens locked on the wrapper. After introducing the special functionswrapandunwrap, conventionalburns became rudimentary.closes #192