Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(integration): all-round protocol happy path #105

Merged
merged 64 commits into from
Aug 2, 2024
Merged

test(integration): all-round protocol happy path #105

merged 64 commits into from
Aug 2, 2024

Conversation

tamtamchik
Copy link
Member

@tamtamchik tamtamchik commented Jun 13, 2024 •
edited
Loading

Added:

Misc:

  • Added .env support for integration tests setup.
  • Added no-shadow ESLint rule (https://typescript-eslint.io/rules/no-shadow) and fixed errors that are already in the code.
  • Updated contribution doc test sections.
  • Changed GH workflows a bit to simplify the setup and make namings more coherent.
  • Updated some dependencies (tracer, hardhat) because current versions cause bugs (tests can hand up)

TODO:

  • Make it work with scratch deploy

@tamtamchik tamtamchik changed the base branch from master to develop July 5, 2024 15:22
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2024 •
edited
Loading

badge

Hardhat Unit Tests Coverage Summary

Filename                                                       Stmts    Miss  Cover    Missing
-----------------------------------------------------------  -------  ------  -------  ---------
contracts/0.4.24/Lido.sol                                        212       0  100.00%
contracts/0.4.24/StETH.sol                                        72       0  100.00%
contracts/0.4.24/StETHPermit.sol                                  15       0  100.00%
contracts/0.4.24/lib/Packed64x4.sol                                5       0  100.00%
contracts/0.4.24/lib/SigningKeys.sol                              36       0  100.00%
contracts/0.4.24/lib/StakeLimitUtils.sol                          37       0  100.00%
contracts/0.4.24/nos/NodeOperatorsRegistry.sol                   485       0  100.00%
contracts/0.4.24/oracle/LegacyOracle.sol                          72       0  100.00%
contracts/0.4.24/utils/Pausable.sol                                9       0  100.00%
contracts/0.4.24/utils/Versioned.sol                               5       0  100.00%
contracts/0.6.12/WstETH.sol                                       17       0  100.00%
contracts/0.8.4/WithdrawalsManagerProxy.sol                       61       0  100.00%
contracts/0.8.9/BeaconChainDepositor.sol                          21       2  90.48%   48, 51
contracts/0.8.9/Burner.sol                                        71       0  100.00%
contracts/0.8.9/DepositSecurityModule.sol                        104       0  100.00%
contracts/0.8.9/EIP712StETH.sol                                   16       0  100.00%
contracts/0.8.9/LidoExecutionLayerRewardsVault.sol                16       0  100.00%
contracts/0.8.9/LidoLocator.sol                                   18       0  100.00%
contracts/0.8.9/OracleDaemonConfig.sol                            28       0  100.00%
contracts/0.8.9/StakingRouter.sol                                303       0  100.00%
contracts/0.8.9/WithdrawalQueue.sol                               88       0  100.00%
contracts/0.8.9/WithdrawalQueueBase.sol                          146       0  100.00%
contracts/0.8.9/WithdrawalQueueERC721.sol                         89       0  100.00%
contracts/0.8.9/WithdrawalVault.sol                               21       0  100.00%
contracts/0.8.9/lib/Math.sol                                       4       0  100.00%
contracts/0.8.9/lib/PositiveTokenRebaseLimiter.sol                22       0  100.00%
contracts/0.8.9/lib/UnstructuredRefStorage.sol                     2       0  100.00%
contracts/0.8.9/oracle/AccountingOracle.sol                      171       1  99.42%   723
contracts/0.8.9/oracle/BaseOracle.sol                             89       1  98.88%   397
contracts/0.8.9/oracle/HashConsensus.sol                         263       1  99.62%   1005
contracts/0.8.9/oracle/ValidatorsExitBusOracle.sol                91      91  0.00%    96-461
contracts/0.8.9/proxy/OssifiableProxy.sol                         17       0  100.00%
contracts/0.8.9/sanity_checks/OracleReportSanityChecker.sol      171       0  100.00%
contracts/0.8.9/utils/DummyEmptyContract.sol                       0       0  100.00%
contracts/0.8.9/utils/PausableUntil.sol                           31       0  100.00%
contracts/0.8.9/utils/Versioned.sol                               11       0  100.00%
contracts/0.8.9/utils/access/AccessControl.sol                    23       0  100.00%
contracts/0.8.9/utils/access/AccessControlEnumerable.sol           9       0  100.00%
TOTAL                                                           2851      96  96.63%

Diff against master

Filename                                                       Stmts    Miss  Cover
-----------------------------------------------------------  -------  ------  --------
contracts/0.8.9/sanity_checks/OracleReportSanityChecker.sol      -54       0  +100.00%
TOTAL                                                            -54       0  -0.03%

Results for commit: e673c52

Minimum allowed coverage is 0%

♻️ This comment has been updated with latest results

@tamtamchik tamtamchik force-pushed the feat/integration branch 4 times, most recently from aaaa88c to 15b0f27 Compare July 8, 2024 19:54
@tamtamchik tamtamchik force-pushed the feat/integration branch 2 times, most recently from 31ef0ec to 824e7a1 Compare July 8, 2024 20:07
@TheDZhon TheDZhon added the tests Pull requests that add or update tests. label Jul 9, 2024
mymphe
mymphe reviewed Jul 26, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
lib/bigint-math.ts Show resolved Hide resolved
lib/protocol/discovery.ts Outdated Show resolved Hide resolved
lib/protocol/types.ts Outdated Show resolved Hide resolved
lib/protocol/helpers/nor.helper.ts Outdated Show resolved Hide resolved
test/integration/burn-shares.ts Outdated Show resolved Hide resolved
test/integration/burn-shares.ts Outdated Show resolved Hide resolved
test/integration/protocol-happy-path.ts Outdated Show resolved Hide resolved
test/integration/protocol-happy-path.ts Outdated Show resolved Hide resolved
@tamtamchik tamtamchik mentioned this pull request Jul 26, 2024
Merged
@tamtamchik
Merge branch 'repovation' into feat/integration
475bf79 
# Conflicts:
#	test/0.4.24/lib/stakeLimitUtils.test.ts
#	test/0.8.9/sanityChecks/baseOracleReportSanityChecker.test.ts
@tamtamchik tamtamchik mentioned this pull request Jul 29, 2024
Open
Ivan-Feofanov pushed a commit to lidofinance/scripts that referenced this pull request Jul 29, 2024
@tamtamchik @Ivan-Feofanov
feat: cleanup of ported to core repo integration tests
a559ea1 
lidofinance/core#105 – contains `test_all_round_happy_path.py` test
@tamtamchik tamtamchik merged commit 0899c39 into repovation Aug 2, 2024
9 checks passed
@tamtamchik tamtamchik deleted the feat/integration branch August 2, 2024 11:47
@tamtamchik tamtamchik mentioned this pull request Aug 2, 2024
Merged
@tamtamchik tamtamchik mentioned this pull request Aug 26, 2024
Open
37 tasks
Ivan-Feofanov pushed a commit to lidofinance/scripts that referenced this pull request Sep 9, 2024
@tamtamchik @Ivan-Feofanov
feat: cleanup of ported to core repo integration tests
296ee4f 
lidofinance/core#105 – contains `test_all_round_happy_path.py` test
@tamtamchik tamtamchik self-assigned this Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vp4242 vp4242 vp4242 left review comments

@mymphe mymphe mymphe approved these changes

@TheDZhon TheDZhon Awaiting requested review from TheDZhon

Assignees

@tamtamchik tamtamchik

Labels
tests Pull requests that add or update tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move integration/scenario tests for protocol to this repo
4 participants
@tamtamchik @mymphe @vp4242 @TheDZhon