Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Submitting Ether to the pool consumes prohibitively high amount of gas #105

Closed
skozin opened this issue Nov 4, 2020 · 0 comments · Fixed by #107
Closed

Submitting Ether to the pool consumes prohibitively high amount of gas #105

skozin opened this issue Nov 4, 2020 · 0 comments · Fixed by #107
Assignees
@ujenjt
Milestone
RC2

Comments

@skozin
Copy link
Member

skozin commented Nov 4, 2020 •
edited
Loading

Currently, submitting even a small amount of Ether to the pool consumes a lot of gas, see #82 (comment). This can be fixed by moving staking to a separate function in Lido.sol:

  • When a user submits Ether to the pool, it gets buffered and tokens are minted.
  • Actual staking of the buffered Ether happens in a separate function (which can be called by anyone).
@skozin skozin added this to the RC2 milestone Nov 4, 2020
@ujenjt ujenjt mentioned this issue Nov 5, 2020
Merged
@skozin skozin mentioned this issue Nov 6, 2020
Closed
tamtamchik added a commit that referenced this issue Sep 30, 2024
@tamtamchik
Merge pull request #105 from lidofinance/feat/integration
0899c39 
test(integration): all-round protocol happy path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ujenjt ujenjt

Labels
None yet
Projects
None yet
Milestone
RC2
Development

Successfully merging a pull request may close this issue.

Extract deposits assigning for node operators into the separate tx lidofinance/core
2 participants
@ujenjt @skozin